Lots of changes to PBP parser#10
Open
rsummers618 wants to merge 11 commits intorcfbanalysis:masterfrom
Open
Conversation
Added advanced Play_Stats stuff Merged Remote parser with local branch Conflicts: ESPN_Scraper/ESPN_Parser/ESPN_Parser.py ESPN_Scraper/ESPN_Parser/Play_Stats.py
New PBP scraper with New ESPN Format OVerhauled PBP parser with new functionality
Merged local branch with Remote, Had to change a few things, Worked first round through testing, Only a few issues with abbreviation conflicts Conflicts: ESPN_Scraper/ESPN_Parser/ESPN_Parser.py ESPN_Scraper/ESPN_Parser/Game.py ESPN_Scraper/ESPN_Parser/Play_Stats.py ESPN_Scraper/ESPN_Scraper/spiders/boxscoreSpider.py ESPN_Scraper/ESPN_Scraper/spiders/espnSpider.py ESPN_Scraper/ESPN_Scraper/spiders/playbyplaySpider.py
Did a lot of validation Advanced the PBP -> Box Checker This is pretty accurate now
Lots of work on the cross validation, Algorithm in place, just needs some tuning, Uses brute force
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything works, Just ran it for 2015,
Main fixes were advanced Parsing and scraping of new ESPN PBP Data
Only issue is that we need to figure out a better way to do the team.csv and abbrev.csv
Still getting issues with teams.
Mcnesse state confused with new mexico state causing crash,
Charlotte 49ers doesn't exist in NCAA etc