Add peer security configuration#21
Open
rchatham wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PeerConnectivity-security.planas the phased security roadmap for PeerConnectivityPeerSecurityConfiguration,PeerCertificatePolicy, andPeerInvitationPolicyMCSessioncreation.receivedCertificateas an observation-only compatibility eventPeerDiscoveryInfosupport for advertised Bonjour discovery metadatafoundPeerWithDiscoveryInfowhile preserving existingfoundPeerevents.automaticinvitation acceptance with policy-based handling.receivedInvitationfor manual invitation policy and non-automatic connection typesPeerConnectivityUIbrowser peer filtering via discovery metadataVerification
git diff --checkswift build && swift testswift testafter Phase 2 discovery metadata changesswift testafter Phase 3 invitation policy changesswift testafter Phase 4 validation/privacy hardening changesswift testafter Phase 5 browser filtering changesswift testafter certificate compatibility fixswift testafter demo coverage changesxcodebuild build -workspace PeerConnectivity.xcworkspace -scheme PeerConnectivityUI -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.3.1' -configuration Debugxcodebuild test -workspace PeerConnectivity.xcworkspace -scheme PeerConnectivity -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.3.1' -configuration Debugxcodebuild build -project PeerConnectivityDemo.xcodeproj -scheme PeerConnectivityDemo -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.3.1' -configuration DebugNotes
PeerSecurityConfiguration.certificatePolicy..receivedCertificateremains observable for API compatibility, but its supplied handler is observation-only and does not affect the certificate decision..foundPeer(peer:)events are preserved; metadata is exposed through the additional.foundPeerWithDiscoveryInfo(peer:discoveryInfo:)event.PeerConnectionEventhas a new.foundPeerWithDiscoveryInfo(peer:discoveryInfo:)case. Existing exhaustive switches overPeerConnectionEventmay need a new case ordefault.Follow-up