fix: NamedGraphError reports the offending graph IRI#82
Open
jeswr wants to merge 1 commit into
Open
Conversation
The error message interpolated quad.value, which is always the empty string for an RDF/JS Quad, so the message never named the graph that caused the failure. Use quad.graph.value instead, and add a regression test asserting the thrown message contains the offending graph IRI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
NamedGraphError's message interpolatedquad.value, which is always the empty string for an RDF/JS Quad, so the error read:and never told you which graph caused the failure. This changes the interpolation to
quad.graph.valueso the message reports the offending graph IRI, and adds a regression test intest/unit/named_graph.test.tsasserting the thrown message contains that IRI.No API change: the constructor signature and error hierarchy are untouched.
Related issues / PRs
NamedGraphErrormessage fix (quad.value->quad.graph.value). The accompanyingQuad->BaseQuadsignature change in Omnibus #73 belongs to the scoped-dataset refactor and is deliberately not included here.