This repository was archived by the owner on Jun 27, 2024. It is now read-only.
Fixing Charset in Content-Disposition of DataExporter#35
Open
agriesbaum wants to merge 1 commit intordicroce:masterfrom
Open
Fixing Charset in Content-Disposition of DataExporter#35agriesbaum wants to merge 1 commit intordicroce:masterfrom
agriesbaum wants to merge 1 commit intordicroce:masterfrom
Conversation
Given CharSet has a typo in UTF8. Has to be UTF-8. Chrome and Firefox can deal with it but IE 11 does not recognize the correct filename.
Author
|
Hey, any comments on this? |
Owner
|
Sorry, I'm not sure when I'll have time to test this change. I'm not sure when the next release will be but I'll try to fit this in. |
|
Man... this issue happens in IE9/IE10/IE11 and Edge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given CharSet has a typo in UTF8. Has to be UTF-8. Chrome and Firefox
can deal with it but IE 11 does not recognize the correct filename.