RDKCOM-5543: RDKBWIFI-364 : Generalizing bus abstraction functions for retrieving and setting bus data property types.#14
Merged
gsathish86 merged 1 commit intordkcentral:developfrom Mar 24, 2026
Conversation
Aniket0606
reviewed
Mar 12, 2026
Aniket0606
left a comment
Aniket0606
left a comment
There was a problem hiding this comment.
The changes look good. Please make sure all platform builds pass and ask QA to perform a sanity test.
amarnathhullur
approved these changes
Mar 13, 2026
Contributor
There was a problem hiding this comment.
Approved,
Dependent change to get merged along with this
rdkcentral/OneWifi#969
amarnathhullur
previously approved these changes
Mar 13, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the WiFi emulator’s RBUS/bus abstraction to use bus_data_prop_t (property-aware payloads) instead of the older generic raw_data_t in subscription/method callback paths, and aligns a couple of consumers with the new callback signature.
Changes:
- Switched the UI webconfig subscription callback to consume
bus_data_prop_tpayloads (and added basic payload validation). - Reworked RBUS object parsing/serialization to populate and free
bus_data_prop_t(including multi-property objects). - Updated the stats-get test subscription handler signature to match the new callback payload type.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/ui/wlan_emu_ui_mgr.cpp |
Updates set_webconfig_cci_data callback signature and reads string payload from bus_data_prop_t. |
inc/wlan_emu_ui_mgr.h |
Updates callback and function-pointer types to bus_data_prop_t*. |
src/bus/rdkb/wlan_emu_bus.cpp |
Adds bus_data_prop_t parsing/freeing and updates RBUS sub/method handlers to use it. |
src/tests/wlan_emu_test_param_stats_get.cpp |
Updates stats subscription callback signature to bus_data_prop_t*. |
inc/wlan_emu_test_params.h |
Updates stats subscription callback declaration to bus_data_prop_t*. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AkhilaReddyK7
changed the title
…and setting bus data property types. Reason for change : Converted the generic raw_data type to bus_data_prop_t. Risks: Medium Test Procedure: Flash the image and verify that all OneWifi-related features work properly.
amarnathhullur
force-pushed
the
bus_gen_change
branch
from
964e105 to
05db866
Compare
narendradandu
approved these changes
Mar 23, 2026
gsathish86
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change : Converted the generic raw_data type to bus_data_prop_t.
Risks: Medium
Test Procedure: Flash the image and verify that all Wifi-related features work properly.