RDKBWIFI-364 : Generalizing bus abstraction functions for retrieving and setting bus data property types.#18
Open
hp490 wants to merge 1 commit intordkcentral:developfrom
Open
RDKBWIFI-364 : Generalizing bus abstraction functions for retrieving and setting bus data property types.#18hp490 wants to merge 1 commit intordkcentral:developfrom
hp490 wants to merge 1 commit intordkcentral:developfrom
Conversation
…and setting bus data property types. Reason for change : Converted the generic raw_data type to bus_data_prop_t. Risks: Medium Test Procedure: Flash the image and verify that all OneWifi-related features work properly.
There was a problem hiding this comment.
Pull request overview
This PR updates the WiFi emulator’s bus callback/data handling to use the newer bus_data_prop_t representation (instead of the legacy raw_data_t payload) and adapts UI + test event handlers accordingly.
Changes:
- Updated UI manager and test subscription callbacks to accept
bus_data_prop_t*and added stricter payload/context validation. - Improved allocation/error-handling paths (e.g.,
std::nothrow, centralized cleanup, consistentnew[]/delete[]usage). - Enhanced RBUS bridge to parse/set RBUS object properties into/from
bus_data_prop_tchains, with explicit cleanup.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/wlan_emu_ui_mgr.cpp | Updates webconfig bus event callback signature to bus_data_prop_t*, adds validation and safer allocation. |
| src/tests/wlan_emu_test_param_stats_get.cpp | Updates stats subscription callback signature and strengthens cleanup/error handling. |
| src/bus/rdkb/wlan_emu_bus.cpp | Adds conversion/free helpers for bus_data_prop_t and updates RBUS sub/method handlers to use it. |
| inc/wlan_emu_ui_mgr.h | Updates callback/function-pointer declarations to bus_data_prop_t*. |
| inc/wlan_emu_test_params.h | Updates stats callback declaration to bus_data_prop_t*. |
Comments suppressed due to low confidence (1)
src/ui/wlan_emu_ui_mgr.cpp:4863
userDatais used later to obtainptr, so the(void)userData;suppression is now stale. Alsolenis assigned frombus_data->value.raw_data_lenbut never used. Please remove the unused suppression/variable (or uselenmeaningfully) to avoid dead code and keep warnings meaningful.
(void)userData;
int len = 0;
char *pTmp = NULL;
webconfig_subdoc_data_t *data = NULL;
wlan_emu_ui_mgr_t *ptr;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change : Converted the generic raw_data type to bus_data_prop_t.
Risks: Medium
Test Procedure: Flash the image and verify that all OneWifi-related features work properly.