Skip to content

RDKBWIFI-364 : Generalizing bus abstraction functions for retrieving and setting bus data property types.#18

Open
hp490 wants to merge 1 commit intordkcentral:developfrom
hp490:bus_new
Open

RDKBWIFI-364 : Generalizing bus abstraction functions for retrieving and setting bus data property types.#18
hp490 wants to merge 1 commit intordkcentral:developfrom
hp490:bus_new

Conversation

@hp490
Copy link
Copy Markdown
Contributor

@hp490 hp490 commented Mar 30, 2026

Reason for change : Converted the generic raw_data type to bus_data_prop_t.
Risks: Medium
Test Procedure: Flash the image and verify that all OneWifi-related features work properly.

…and setting bus data property types.

Reason for change : Converted the generic raw_data type to bus_data_prop_t.
Risks: Medium
Test Procedure: Flash the image and verify that all OneWifi-related features work properly.
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WiFi emulator’s bus callback/data handling to use the newer bus_data_prop_t representation (instead of the legacy raw_data_t payload) and adapts UI + test event handlers accordingly.

Changes:

  • Updated UI manager and test subscription callbacks to accept bus_data_prop_t* and added stricter payload/context validation.
  • Improved allocation/error-handling paths (e.g., std::nothrow, centralized cleanup, consistent new[]/delete[] usage).
  • Enhanced RBUS bridge to parse/set RBUS object properties into/from bus_data_prop_t chains, with explicit cleanup.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/ui/wlan_emu_ui_mgr.cpp Updates webconfig bus event callback signature to bus_data_prop_t*, adds validation and safer allocation.
src/tests/wlan_emu_test_param_stats_get.cpp Updates stats subscription callback signature and strengthens cleanup/error handling.
src/bus/rdkb/wlan_emu_bus.cpp Adds conversion/free helpers for bus_data_prop_t and updates RBUS sub/method handlers to use it.
inc/wlan_emu_ui_mgr.h Updates callback/function-pointer declarations to bus_data_prop_t*.
inc/wlan_emu_test_params.h Updates stats callback declaration to bus_data_prop_t*.
Comments suppressed due to low confidence (1)

src/ui/wlan_emu_ui_mgr.cpp:4863

  • userData is used later to obtain ptr, so the (void)userData; suppression is now stale. Also len is assigned from bus_data->value.raw_data_len but never used. Please remove the unused suppression/variable (or use len meaningfully) to avoid dead code and keep warnings meaningful.
    (void)userData;
    int len = 0;
    char *pTmp = NULL;
    webconfig_subdoc_data_t *data = NULL;
    wlan_emu_ui_mgr_t *ptr;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants