Skip to content

[Messaging] Add Telemetry as a new messaging type#2090

Open
VeithMetro wants to merge 9 commits intomasterfrom
development/messaging-telemetry
Open

[Messaging] Add Telemetry as a new messaging type#2090
VeithMetro wants to merge 9 commits intomasterfrom
development/messaging-telemetry

Conversation

@VeithMetro
Copy link
Copy Markdown
Contributor

@VeithMetro VeithMetro commented Apr 3, 2026

When this is in, we will also need these adjustments in MessageControl

Copilot AI review requested due to automatic review settings April 3, 2026 08:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Telemetry messaging type to Thunder’s messaging subsystem, including control macros, config support, and a new typed telemetry event payload.

Changes:

  • Introduces TelemetryControl.h and exposes it via messaging.h / CMakeLists.txt.
  • Extends messaging configuration to include a telemetry section and allows TELEMETRY in settings parsing.
  • Adds Core::Messaging::TelemetryMessage and Metadata::type::TELEMETRY plumbing (enum + conversions).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Source/messaging/TelemetryControl.h New telemetry category/control utilities and TELEMETRY push macro.
Source/messaging/messaging.h Exposes telemetry control header via umbrella include.
Source/messaging/MessageUnit.h Adds telemetry section to settings/config and extends accepted type range.
Source/messaging/CMakeLists.txt Installs TelemetryControl.h as a public header.
Source/core/Messaging.h Adds TelemetryMessage (typed payload) API and declarations.
Source/core/Messaging.cpp Implements TelemetryMessage serialization/deserialization.
Source/core/MessageStore.h Adds TELEMETRY enum value, defaulting behavior, and IStore::Telemetry metadata wrapper.
Source/core/MessageStore.cpp Adds enum string conversion and module-serialization handling for TELEMETRY metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings April 3, 2026 11:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings April 3, 2026 12:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 3, 2026 12:43
…nness

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@VeithMetro VeithMetro requested a review from sebaszm April 3, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants