[Messaging] Add Telemetry as a new messaging type#2090
[Messaging] Add Telemetry as a new messaging type#2090VeithMetro wants to merge 9 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Telemetry messaging type to Thunder’s messaging subsystem, including control macros, config support, and a new typed telemetry event payload.
Changes:
- Introduces
TelemetryControl.hand exposes it viamessaging.h/CMakeLists.txt. - Extends messaging configuration to include a
telemetrysection and allows TELEMETRY in settings parsing. - Adds
Core::Messaging::TelemetryMessageandMetadata::type::TELEMETRYplumbing (enum + conversions).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Source/messaging/TelemetryControl.h | New telemetry category/control utilities and TELEMETRY push macro. |
| Source/messaging/messaging.h | Exposes telemetry control header via umbrella include. |
| Source/messaging/MessageUnit.h | Adds telemetry section to settings/config and extends accepted type range. |
| Source/messaging/CMakeLists.txt | Installs TelemetryControl.h as a public header. |
| Source/core/Messaging.h | Adds TelemetryMessage (typed payload) API and declarations. |
| Source/core/Messaging.cpp | Implements TelemetryMessage serialization/deserialization. |
| Source/core/MessageStore.h | Adds TELEMETRY enum value, defaulting behavior, and IStore::Telemetry metadata wrapper. |
| Source/core/MessageStore.cpp | Adds enum string conversion and module-serialization handling for TELEMETRY metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…al/Thunder into development/messaging-telemetry
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nness Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…Size would be exactly 1
When this is in, we will also need these adjustments in MessageControl