Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies the error logging in toHexString() within the device info CLI/sample code.
Changes:
- Updates the
printfcall in the buffer-too-small branch oftoHexString().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| } else { | ||
| printf("ERROR: bufLength %d is too small for %d chars\n", *bufLength, totalLength); | ||
| printf("ERROR: bufLength %d is too small for %d chars\n", totalLength); |
There was a problem hiding this comment.
The printf format string expects two integer arguments ("%d" twice), but only one argument (totalLength) is provided. This is undefined behavior and will likely print garbage/crash. Pass both *bufLength and totalLength (and consider using "%u"/casting since these are uint32_t) to match the format string.
Suggested change
| printf("ERROR: bufLength %d is too small for %d chars\n", totalLength); | |
| printf("ERROR: bufLength %u is too small for %u chars\n", *bufLength, totalLength); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.