Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears to be a temporary/test change (per title/description “DO NOT MERGE”) and modifies error logging in the device_info utility’s hex conversion helper.
Changes:
- Updated the
printfcall intoHexString()when the provided output buffer is too small.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| } else { | ||
| printf("ERROR: bufLength %d is too small for %d chars\n", *bufLength, totalLength); | ||
| printf("ERROR: bufLength %d is too small for %d chars\n", totalLength); |
There was a problem hiding this comment.
printf format string expects two integer arguments (%d ... %d) but only one argument (totalLength) is provided here. This is undefined behavior and will often crash or print garbage. Pass both values (e.g., current *bufLength and required totalLength) or adjust the format string to match the arguments; also consider using an unsigned/PRIu32 format since these are uint32_t.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE