Skip to content

Make type const in Unregister methods #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nxtum wants to merge 2 commits into from
Closed

Make type const in Unregister methods #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8faf419
const for consistency
nxtum Feb 16, 2026
652665e
add istore2.h
nxtum Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion interfaces/IAmazonPrime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace Exchange {
};

virtual void Register(IAmazonPrime::INotification* ignition) = 0;
virtual void Unregister(IAmazonPrime::INotification* ignition) = 0;
virtual void Unregister(const IAmazonPrime::INotification* ignition) = 0;

// @brief Send a message over the message bus to ignition
// @param messsage: The message to send according the amazon spec found
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IApplication.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ namespace Exchange {
};

virtual void Register(INotification* sink) = 0;
virtual void Unregister(INotification* sink) = 0;
virtual void Unregister(const INotification* sink) = 0;
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the Unregister parameter type from INotification* to const INotification* is a breaking API/ABI change for all implementers of this interface (their overrides must be updated and any binary plugins built against the previous header will no longer match). If these Exchange interfaces are consumed across independently-built components, consider versioning the interface (new ID / new interface type) or otherwise documenting/releasing this as a coordinated breaking change.

Suggested change
virtual void Unregister(const INotification* sink) = 0;
virtual void Unregister(INotification* sink) = 0;

Copilot uses AI. Check for mistakes.

// @brief Resets application data
// @param type: Type of reset to perform
Expand Down
6 changes: 3 additions & 3 deletions interfaces/IBrowser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace Exchange {
};

virtual void Register(IBrowser::INotification* sink) = 0;
virtual void Unregister(IBrowser::INotification* sink) = 0;
virtual void Unregister(const IBrowser::INotification* sink) = 0;

// Change the currently displayed URL by the browser.
virtual void SetURL(const string& URL) = 0;
Expand Down Expand Up @@ -96,7 +96,7 @@ namespace Exchange {
};

virtual void Register(INotification* sink) = 0;
virtual void Unregister(INotification* sink) = 0;
virtual void Unregister(const INotification* sink) = 0;

// @property
// @brief Page loaded in the browser
Expand Down Expand Up @@ -264,7 +264,7 @@ namespace Exchange {
};

virtual void Register(INotification* sink) = 0;
virtual void Unregister(INotification* sink) = 0;
virtual void Unregister(const INotification* sink) = 0;

// @property
// @brief Get/Set CookieJar config details
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IComposition.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ namespace Exchange {
};

virtual void Register(IComposition::INotification* notification) = 0;
virtual void Unregister(IComposition::INotification* notification) = 0;
virtual void Unregister(const IComposition::INotification* notification) = 0;

virtual uint32_t Configure(PluginHost::IShell* service) = 0;

Expand Down
2 changes: 1 addition & 1 deletion interfaces/IContentDecryption.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ namespace Exchange {
};

virtual uint32_t Register(IContentDecryption::INotification* notification VARIABLE_IS_NOT_USED) { return Core::ERROR_NOT_SUPPORTED; };
virtual uint32_t Unregister(IContentDecryption::INotification* notification VARIABLE_IS_NOT_USED) { return Core::ERROR_NOT_SUPPORTED; };
virtual uint32_t Unregister(const IContentDecryption::INotification* notification VARIABLE_IS_NOT_USED) { return Core::ERROR_NOT_SUPPORTED; };
};

class DataExchange : public Core::SharedBuffer {
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IContentProtection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ namespace Exchange {
};

virtual uint32_t Register(INotification* notification) = 0;
virtual uint32_t Unregister(INotification* notification) = 0;
virtual uint32_t Unregister(const INotification* notification) = 0;

// @alt openDrmSession
// @param clientId client that establishes the playback session
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IDisplayInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ namespace Exchange {
};

virtual uint32_t Register(INotification*) = 0;
virtual uint32_t Unregister(INotification*) = 0;
virtual uint32_t Unregister(const INotification*) = 0;

// @property
// @brief Current audio passthrough status on HDMI
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IDolby.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ namespace Exchange {
};

virtual uint32_t Register(INotification*) = 0;
virtual uint32_t Unregister(INotification*) = 0;
virtual uint32_t Unregister(const INotification*) = 0;

// @property
// @text dolbyatmossupported @alt:deprecated dolby_atmosmetadata
Expand Down
4 changes: 2 additions & 2 deletions interfaces/IExternal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ namespace Exchange {

// Pushing notifications to interested sinks
virtual void Register(ICatalog::INotification* sink) = 0;
virtual void Unregister(ICatalog::INotification* sink) = 0;
virtual void Unregister(const ICatalog::INotification* sink) = 0;
virtual IExternal* Resource(const uint32_t id) = 0;
};

Expand All @@ -61,7 +61,7 @@ namespace Exchange {

// Pushing notifications to interested sinks
virtual void Register(INotification* sink) = 0;
virtual void Unregister(INotification* sink) = 0;
virtual void Unregister(const INotification* sink) = 0;

// Element require communication, so might fail, report our condition
virtual condition Condition() const = 0;
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IExternalBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ POP_WARNING()

_adminLock.Unlock();
}
void Unregister(IExternal::INotification* sink) override
void Unregister(const IExternal::INotification* sink) override
{

_adminLock.Lock();
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IGuide.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ namespace Exchange {
virtual bool IsParentalLocked(const string&) = 0;

virtual void Register(IGuide::INotification*) = 0;
virtual void Unregister(IGuide::INotification*) = 0;
virtual void Unregister(const IGuide::INotification*) = 0;
};
}
}
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IInputPin.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ namespace Exchange {
~IInputPin() override = default;

virtual void Register(IInputPin::INotification* sink) = 0;
virtual void Unregister(IInputPin::INotification* sink) = 0;
virtual void Unregister(const IInputPin::INotification* sink) = 0;

virtual void AddMarker(const uint32_t marker) = 0;
virtual void RemoveMarker(const uint32_t marker) = 0;
Expand Down
2 changes: 1 addition & 1 deletion interfaces/ILISA.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ namespace Exchange {
};

virtual uint32_t Register(ILISA::INotification* notification) = 0;
virtual uint32_t Unregister(ILISA::INotification* notification) = 0;
virtual uint32_t Unregister(const ILISA::INotification* notification) = 0;
virtual uint32_t Configure(const std::string& config) = 0;

struct EXTERNAL IAppVersion : virtual public Core::IUnknown {
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IMediaPlayer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ struct IMediaPlayer : virtual public Core::IUnknown {
virtual uint32_t InitConfig(const string& configurationJson) = 0;
virtual uint32_t InitDRMConfig(const string& configurationJson) = 0;
virtual uint32_t Register(INotification* notification) = 0;
virtual uint32_t Unregister(INotification* notification) = 0;
virtual uint32_t Unregister(const INotification* notification) = 0;
};

~IMediaPlayer() override = default;
Expand Down
2 changes: 1 addition & 1 deletion interfaces/INetflix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace Exchange {
};

virtual void Register(INetflix::INotification* netflix) = 0;
virtual void Unregister(INetflix::INotification* netflix) = 0;
virtual void Unregister(const INetflix::INotification* netflix) = 0;

virtual void SystemCommand(const string& command) = 0;
};
Expand Down
2 changes: 1 addition & 1 deletion interfaces/INetworkControl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ namespace Exchange {

// Pushing notifications to interested sinks
virtual uint32_t Register(INetworkControl::INotification* sink) = 0;
virtual uint32_t Unregister(INetworkControl::INotification* sink) = 0;
virtual uint32_t Unregister(const INetworkControl::INotification* sink) = 0;

// @property
// @brief Currently available interfaces
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IPackageManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ namespace Exchange {
};

virtual uint32_t Register(IPackageManager::INotification* notification) = 0;
virtual uint32_t Unregister(IPackageManager::INotification* notification) = 0;
virtual uint32_t Unregister(const IPackageManager::INotification* notification) = 0;

struct EXTERNAL PackageKey {
string id /* @brief Unique identifier of the package */;
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IProvisioning.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ namespace Exchange {
};

virtual void Register(IProvisioning::INotification* provisioning) = 0;
virtual void Unregister(IProvisioning::INotification* provisioning) = 0;
virtual void Unregister(const IProvisioning::INotification* provisioning) = 0;
virtual uint32_t DeviceId (string& deviceId /* @out */) const = 0;
virtual uint32_t DRMId (const string& label /* @in */, uint16_t& size /* @inout */, uint8_t data[] /* @length:size @out */) const = 0;
};
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IRPCLink.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace Exchange {
};

virtual void Register(INotification* notification) = 0;
virtual void Unregister(INotification* notification) = 0;
virtual void Unregister(const INotification* notification) = 0;

virtual uint32_t Start(const uint32_t id, const string& name) = 0;
virtual uint32_t Stop() = 0;
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IRemoteControl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace Exchange {
};

virtual void RegisterEvents(INotification* sink) = 0;
virtual void UnregisterEvents(INotification* sink) = 0;
virtual void UnregisterEvents(const INotification* sink) = 0;
};
}
}
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IStore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ struct EXTERNAL IStore : virtual public Core::IUnknown {
};

virtual uint32_t Register(Exchange::IStore::INotification *notification) = 0;
virtual uint32_t Unregister(Exchange::IStore::INotification *notification) = 0;
virtual uint32_t Unregister(const Exchange::IStore::INotification *notification) = 0;
virtual uint32_t SetValue(const string &ns, const string &key, const string &value) = 0;
virtual uint32_t GetValue(const string &ns, const string &key, string &value /* @out */) = 0;
virtual uint32_t DeleteKey(const string &ns, const string &key) = 0;
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IStore2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ namespace Exchange {
};

virtual uint32_t Register(Exchange::IStore2::INotification* notification) = 0;
virtual uint32_t Unregister(Exchange::IStore2::INotification* notification) = 0;
virtual uint32_t Unregister(const Exchange::IStore2::INotification* notification) = 0;

// @alt setValue
virtual uint32_t SetValue(const ScopeType scope, const string& ns /* @text:namespace */, const string& key, const string& value, const uint32_t ttl) = 0;
Expand Down
2 changes: 1 addition & 1 deletion interfaces/ISwitchBoard.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace Exchange {
};

virtual void Register(INotification* notification) = 0;
virtual void Unregister(INotification* notification) = 0;
virtual void Unregister(const INotification* notification) = 0;

virtual bool IsActive(const string& callsign) const = 0;
virtual uint32_t Activate(const string& callsign) = 0;
Expand Down
2 changes: 1 addition & 1 deletion interfaces/ISystemAudioPlayer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace Exchange {

virtual uint32_t Configure(PluginHost::IShell* service) = 0;
virtual void Register(INotification* sink) = 0;
virtual void Unregister(INotification* sink) = 0;
virtual void Unregister(const INotification* sink) = 0;

virtual uint32_t Open(const string &input, string &output /* @out */) = 0;
virtual uint32_t Play(const string &input, string &output /* @out */) = 0;
Expand Down
2 changes: 1 addition & 1 deletion interfaces/ITextToSpeech.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ namespace Exchange {
~ITextToSpeech() override = default;

virtual void Register(ITextToSpeech::INotification* sink) = 0;
virtual void Unregister(ITextToSpeech::INotification* sink) = 0;
virtual void Unregister(const ITextToSpeech::INotification* sink) = 0;

// @property
// @brief Query the status/enable tts
Expand Down
2 changes: 1 addition & 1 deletion interfaces/ITimeSync.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace Exchange {
};

virtual void Register(INotification* notification) = 0;
virtual void Unregister(INotification* notification) = 0;
virtual void Unregister(const INotification* notification) = 0;

virtual uint32_t Synchronize() = 0;
virtual void Cancel() = 0;
Expand Down
2 changes: 1 addition & 1 deletion interfaces/ITimeZone.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace Exchange {
};

virtual uint32_t Register(ITimeZone::INotification* sink) = 0;
virtual uint32_t Unregister(ITimeZone::INotification* sink) = 0;
virtual uint32_t Unregister(const ITimeZone::INotification* sink) = 0;

// @property
// @brief TimeZone for system
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IWatermark.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace Exchange {
virtual uint32_t Initialize(string waylandDisplay, bool synchronized) = 0;
virtual uint32_t Deinitialize() = 0;
virtual uint32_t Register(INotification* notification) = 0;
virtual uint32_t Unregister(INotification* notification) = 0;
virtual uint32_t Unregister(const INotification* notification) = 0;
virtual bool ShowWatermark(const bool show) = 0;
virtual bool CreateWatermark(uint32_t id, uint32_t zorder) = 0;
virtual bool UpdateWatermark(uint32_t id, uint32_t key, uint32_t size) = 0;
Expand Down
2 changes: 1 addition & 1 deletion interfaces/IWifiControl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ namespace Exchange {

// Pushing notifications to interested sinks
virtual uint32_t Register(IWifiControl::INotification* sink) = 0;
virtual uint32_t Unregister(IWifiControl::INotification* sink) = 0;
virtual uint32_t Unregister(const IWifiControl::INotification* sink) = 0;

// @property
// @brief Provides available networks information
Expand Down
2 changes: 1 addition & 1 deletion qa_interfaces/ITestController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ namespace Thunder {
virtual void TearDown() = 0;

virtual void Register(ITest* test) = 0;
virtual void Unregister(ITest* test) = 0;
virtual void Unregister(const ITest* test) = 0;
virtual ITest::IIterator* Tests() const = 0;
virtual ITest* Test(const string& name) const = 0;
};
Expand Down
Loading