Skip to content

[Actions] Increase number of context lines in diff, add examples to ProxyStub workflow#244

Merged
VeithMetro merged 6 commits intomasterfrom
development/actions-diff-lines
Mar 19, 2026
Merged

[Actions] Increase number of context lines in diff, add examples to ProxyStub workflow#244
VeithMetro merged 6 commits intomasterfrom
development/actions-diff-lines

Conversation

@VeithMetro
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions generator workflows to produce diffs with more surrounding context, making rendered HTML diffs (diff2html) easier to review for generated outputs.

Changes:

  • Add -U5 (5 context lines) to git diff --no-index invocations across generator workflows.
  • Apply the same diff-context behavior for both baseline-present and baseline-missing branches where applicable.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/ProxyStubGenerator.yml Increase unified context to 5 lines for combined baseline vs generated diffs.
.github/workflows/PluginSkeletonGenerator.yml Increase unified context to 5 lines for per-plugin diffs.
.github/workflows/LuaGenerator.yml Increase unified context to 5 lines for combined baseline vs generated diffs.
.github/workflows/JsonGenerator.yml Increase unified context to 5 lines for combined baseline vs generated diffs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

LuaGenerator Results

View Results

No changes detected.

@github-actions
Copy link
Copy Markdown

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-244/run-23245316004/

No changes detected in generated plugin code. The PR changes are internal to the generator or do not affect output.

@github-actions
Copy link
Copy Markdown

ProxyStubGenerator Results

View Results

No changes detected.

@github-actions
Copy link
Copy Markdown

JsonGenerator Results

View Results

No changes detected.

@VeithMetro VeithMetro changed the title [Actions] Increase the number of context lines in the diff [Actions] Increase number of context lines in diff, add examples to ProxyStub workflow Mar 18, 2026
@github-actions
Copy link
Copy Markdown

LuaGenerator Results

View Results

No changes detected.

@github-actions
Copy link
Copy Markdown

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-244/run-23246790064/

No changes detected in generated plugin code. The PR changes are internal to the generator or do not affect output.

@github-actions
Copy link
Copy Markdown

JsonGenerator Results

View Results

No changes detected.

Copilot AI review requested due to automatic review settings March 18, 2026 16:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@github-actions
Copy link
Copy Markdown

LuaGenerator Results

View Results

No changes detected.

@github-actions
Copy link
Copy Markdown

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-244/run-23255184529/

No changes detected in generated plugin code. The PR changes are internal to the generator or do not affect output.

@github-actions
Copy link
Copy Markdown

JsonGenerator Results

View Results

No changes detected.

@VeithMetro VeithMetro merged commit 9038cbb into master Mar 19, 2026
158 of 168 checks passed
@VeithMetro VeithMetro deleted the development/actions-diff-lines branch March 19, 2026 07:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants