Feature/vpaamp 239 8.4#1552
Open
Gnanesha wants to merge 2 commits into
Open
Conversation
Reason for Change: Enabled info and progress logs to debug the issue Test procedure : please see the ticket risks : low
Reason for Change: Change the CURLOPT_DNS_CACHE_TIMEOUT config to be updated from config not as default * Add L1 test verifying CURLOPT_DNS_CACHE_TIMEOUT uses config value * AampCurlDefine.h: clarify DEFAULT_DNS_CACHE_TIMEOUT comment (180s = 3x libcurl default of 60s) * ( FakeCurl.cpp: route CURLOPT_DNS_CACHE_TIMEOUT through curl_easy_setopt_long mock * ( FunctionalTests.cpp: add DnsCacheTimeout_PassedFromDownloadConfig_NotHardCoded regression test; catches any future hard-coding of dns_cache_timeout instead of reading iDnsCacheTimeOut from DownloadConfig * FunctionalTests.cpp SetUp: allow curl_easy_setopt_long by default so existing tests are not broken by the new FakeCurl routing Test Procedure: refer ticket Risks: Low Priority: P1 --------- Signed-off-by: Anurag Krishnan <akrish513@cable.comcast.com> Co-authored-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.