New ignore file and reworked fossid workflow to reduce false positives by danielsoden0404 · Pull Request #31 · rdkcentral/build_tools_workflows

danielsoden0404 · 2026-02-25T12:09:27Z

In this change I used a script to generate a list of ids of open source Gerrit repos to ignore and included the rdkcentral and rdkcmf ignore wildcards.

I also reworked the workflow file according to advice from fossid in that the image we should be using is fossid-toolbox for diffscan, not fossid-cicd. From here I adjusted some of the flags accordingly

…d-cicd image to fossid-toolbox

Copilot

Pull request overview

This PR updates the FossID pre-merge diff scan setup to reduce false positives by switching to the recommended fossid-toolbox image/CLI and replacing the previous ignore-file approach with a generated ignore list.

Changes:

Added a generated ignored_projects_list containing Gerrit OSS project IDs and GitHub org wildcards to ignore.
Removed the older ignore_projects_fossid ignore file.
Reworked the FossID GitHub Actions workflow to use quay.io/fossid/fossid-toolbox and updated CLI flags/file paths accordingly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
`ignored_projects_list`	Introduces the new generated ignore list used to reduce false positives.
`ignore_projects_fossid`	Deletes the previous ignore file in favor of the new list.
`.github/workflows/fossid_integration_stateless_diffscan.yml`	Switches workflow execution to `fossid-toolbox`/`fossid diffscan` and updates ignore-projects handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ignored_projects_list

.github/workflows/fossid_integration_stateless_diffscan.yml

mhughesacn · 2026-03-03T13:33:31Z

Copilot has a comment about ignored_projects_list being in two different places. Checked in at top level but the yml workflow uses tools/ignored_project_list - is this OK?
Also there is a duplicate in the ignore file - Copilot again.
Can the last two entries in the ignore file go on top as extra entries will likely be appended?
The ignores are just magic numbers as required by fossid. It would be good to include the URLs as well - is a comment possible (?) and if not, to have the projects in a separate file also checked in here.

…mix ups

7de58ed6dfb35940bf3521ed00000000 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/fossid_integration_stateless_diffscan.yml

ignore_projects_fossid

ignored_projects_list

…nclude comments for what we're ignoring

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ignored_projects_list

.github/workflows/fossid_integration_stateless_diffscan.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…st suggested version by fossid

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…xt to ids

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ignored_projects_list

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mhughesacn

Looks good

.github/workflows/fossid_integration_stateless_diffscan.yml

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/fossid_integration_stateless_diffscan.yml

ignore_projects_fossid

copilot whitespace Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mhughesacn

Looks good

added ignore file created from script and corrected issues with fossi…

2ee6c9e

…d-cicd image to fossid-toolbox

Copilot AI review requested due to automatic review settings February 25, 2026 12:09

danielsoden0404 requested a review from a team as a code owner February 25, 2026 12:09

Copilot started reviewing on behalf of danielsoden0404 February 25, 2026 12:09 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

ignored_projects_list Outdated Show resolved Hide resolved

ignored_projects_list Outdated Show resolved Hide resolved

.github/workflows/fossid_integration_stateless_diffscan.yml Show resolved Hide resolved

.github/workflows/fossid_integration_stateless_diffscan.yml Show resolved Hide resolved

danielsoden0404 and others added 2 commits March 3, 2026 14:07

Moved up GitHub wildcards to the top so when new values appended, no …

e9c7188

…mix ups

Update ignored_projects_list removing duplicate 1

e44e42d

7de58ed6dfb35940bf3521ed00000000 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 3, 2026 14:44

Update ignored_projects_list remove whitespace

d2a2d92

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of danielsoden0404 March 3, 2026 14:45 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

.github/workflows/fossid_integration_stateless_diffscan.yml Show resolved Hide resolved

ignore_projects_fossid Show resolved Hide resolved

ignored_projects_list Outdated Show resolved Hide resolved

danielsoden0404 added 2 commits March 4, 2026 10:53

Update ignored_projects_list adjusted script that generates list to i…

37893b4

…nclude comments for what we're ignoring

Update ignored_projects_list clearer ignore list for now

8d82954

Copilot AI review requested due to automatic review settings March 5, 2026 13:07

Copilot started reviewing on behalf of danielsoden0404 March 5, 2026 13:07 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

ignored_projects_list Outdated Show resolved Hide resolved

.github/workflows/fossid_integration_stateless_diffscan.yml Outdated Show resolved Hide resolved

Update ignored_projects_list semantic spelling

006e22a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 5, 2026 13:14

Copilot started reviewing on behalf of danielsoden0404 March 5, 2026 13:15 View session

Update fossid_integration_stateless_diffscan.yml locking down to late…

81c139a

…st suggested version by fossid

Copilot AI reviewed Mar 5, 2026

View reviewed changes

danielsoden0404 added 2 commits March 5, 2026 13:27

Update ignored_projects_list reformatted ignore list with comments ne…

702b8cf

…xt to ids

Update ignored_projects_list comment correction

5dbf69c

Copilot AI review requested due to automatic review settings March 5, 2026 13:41

Copilot started reviewing on behalf of danielsoden0404 March 5, 2026 13:42 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

ignored_projects_list Outdated Show resolved Hide resolved

danielsoden0404 added 2 commits March 5, 2026 14:54

Update ignored_projects_list

680cd49

added whitespace in comment readability

9ddd86e

Copilot AI review requested due to automatic review settings March 5, 2026 15:24

Copilot started reviewing on behalf of danielsoden0404 March 5, 2026 15:24 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

mhughesacn previously approved these changes Mar 5, 2026

View reviewed changes

.github/workflows/fossid_integration_stateless_diffscan.yml Show resolved Hide resolved

renamed file back to ignore_projects_fossid

bdfe076

danielsoden0404 dismissed mhughesacn’s stale review via bdfe076 March 5, 2026 16:01

Merge branch 'develop' into fix/fossid_false_positives_gerrit_github

22ccf4d

Copilot AI review requested due to automatic review settings March 5, 2026 16:05

Copilot AI reviewed Mar 5, 2026

View reviewed changes

.github/workflows/fossid_integration_stateless_diffscan.yml Outdated Show resolved Hide resolved

ignore_projects_fossid Show resolved Hide resolved

Update .github/workflows/fossid_integration_stateless_diffscan.yml

e0591a1

copilot whitespace Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 5, 2026 16:09

Copilot started reviewing on behalf of danielsoden0404 March 5, 2026 16:09 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

mhughesacn approved these changes Mar 5, 2026

View reviewed changes

danielsoden0404 merged commit 22737f9 into develop Mar 5, 2026
10 of 11 checks passed

danielsoden0404 deleted the fix/fossid_false_positives_gerrit_github branch March 5, 2026 16:47

github-actions bot locked and limited conversation to collaborators Mar 5, 2026

Conversation

danielsoden0404 commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mhughesacn commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

mhughesacn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

mhughesacn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants