Skip to content

RDKEMW-16104: Update frameRate.cpp#236

Merged
apatel859 merged 4 commits intosupport/8.5.3.0from
topic/topic/RDKEMW-16104_2
Mar 27, 2026
Merged

RDKEMW-16104: Update frameRate.cpp#236
apatel859 merged 4 commits intosupport/8.5.3.0from
topic/topic/RDKEMW-16104_2

Conversation

@yuvaramachandran-gurusamy
Copy link
Copy Markdown
Contributor

RDKEMW-16104: Update frameRate.cpp

Reason for change: disable the dsVIDEO_FRAMERATE_59 and dsVIDEO_FRAMERATE_23

Copilot AI review requested due to automatic review settings March 27, 2026 13:00
@yuvaramachandran-gurusamy yuvaramachandran-gurusamy requested a review from a team as a code owner March 27, 2026 13:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the FrameRate constant mappings to avoid referencing dsVIDEO_FRAMERATE_59 / dsVIDEO_FRAMERATE_23 (reported as unsupported on some platforms), by mapping them to dsVIDEO_FRAMERATE_UNKNOWN.

Changes:

  • Replaced FrameRate::k59 and FrameRate::k23 definitions with dsVIDEO_FRAMERATE_UNKNOWN.
  • Added an explanatory comment describing the rationale.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 27, 2026 13:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 27, 2026 18:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@apatel859 apatel859 merged commit 5764da2 into support/8.5.3.0 Mar 27, 2026
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants