Skip to content

RDKCOM-5492: RDKBDEV-3336 De-authenticating Hotspot Clients Upon DHCP Failure#32

Open
rhegde114 wants to merge 25 commits intordkcentral:developfrom
rhegde114:snooper_test
Open

RDKCOM-5492: RDKBDEV-3336 De-authenticating Hotspot Clients Upon DHCP Failure#32
rhegde114 wants to merge 25 commits intordkcentral:developfrom
rhegde114:snooper_test

Conversation

@rhegde114
Copy link
Copy Markdown

@rhegde114 rhegde114 commented Jan 6, 2026

  1. dhcpsnooper in hotspot component monitors the DHCP exchange process for newly associated hotspot clients. If a client successfully associates with the Access Point (AP) but does not receive a valid IP address assignment from the DHCP server within a predefined period and automatically trigger a de-authentication for that client.
  2. Implement a data model(
    Device.X_COMCAST-COM_GRE.Hotspot.RejectAssociatedClient)for the Rbus event, which will be triggered whenever a client's DHCP transaction fails to assign an IP address within a specified period (i.e., a timeout).

rhegde114 and others added 6 commits December 15, 2025 15:38
@rhegde114
Description: Monitor DHCP packet in packet handler and
d5b8606 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
@rhegde114
Description: Monitor DHCP packet in packet handler and
41ffb24 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
@rhegde114
Description: Monitor DHCP packet in packet handler and
71a7394 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
@rhegde114
Description: Monitor DHCP packet in packet handler and
7071f67 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
@rhegde114
Description: Monitor DHCP packet in packet handler and
626243e 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
@rhegde114
Merge branch 'rdkcentral:develop' into snooper_test
dcc155d
@rhegde114 rhegde114 requested review from a team as code owners January 6, 2026 18:40
@rhegde114 rhegde114 changed the title De-authenticating Hotspot Clients Upon DHCP Failure RDKBDEV-3336:De-authenticating Hotspot Clients Upon DHCP Failure Jan 6, 2026
@rhegde114
Description: Monitor DHCP packet in packet handler and
d66ad42 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
Reason for change: Improvement to disassoc hotspot client
                   when dhcp has not assigned ip address
                   within 4 secs

Test Procedure: 1.Connect a client device to the hotspot VAP
                2.Wait for 4 seconds and verify that the client
                  successfully associates with the Access Point
                  (AP) but does not receive a valid IP address
                  from the DHCP server

Risks: None

Signed-off-by: raghavendra.hegde2@comcast.com
@pradeeptakdas pradeeptakdas changed the title RDKBDEV-3336:De-authenticating Hotspot Clients Upon DHCP Failure RDKCOM-5492: RDKBDEV-3336 De-authenticating Hotspot Clients Upon DHCP Failure Jan 7, 2026
rhegde114 and others added 6 commits January 20, 2026 11:17
@rhegde114
Description: Monitor DHCP packet in packet handler and
4effa6c 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
Reason for change: Improvement to disassoc hotspot client
                   when dhcp has not assigned ip address
                   within 4 secs

Test Procedure: 1.Connect a client device to the hotspot VAP
                2.Wait for 4 seconds and verify that the client
                  successfully associates with the Access Point
                  (AP) but does not receive a valid IP address
                  from the DHCP server

Risks: None

Signed-off-by: raghavendra.hegde2@comcast.com
@rhegde114
Revert "Description: Monitor DHCP packet in packet handler and"
be7401e 
This reverts commit 4effa6c.
@rhegde114
Description: Monitor DHCP packet in packet handler and
0d4fbed 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
Reason for change: Improvement to disassoc hotspot client
                   when dhcp has not assigned ip address
                   within 4 secs

Test Procedure: 1.Connect a client device to the hotspot VAP
                2.Wait for 4 seconds and verify that the client
                  successfully associates with the Access Point
                  (AP) but does not receive a valid IP address
                  from the DHCP server

Risks: None

Signed-off-by: raghavendra.hegde2@comcast.com
@rhegde114
Description: Monitor DHCP packet in packet handler and
f63c619 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
Reason for change: Improvement to disassoc hotspot client
                   when dhcp has not assigned ip address
                   within 4 secs

Test Procedure: 1.Connect a client device to the hotspot VAP
                2.Wait for 4 seconds and verify that the client
                  successfully associates with the Access Point
                  (AP) but does not receive a valid IP address
                  from the DHCP server

Risks: None

Signed-off-by: raghavendra.hegde2@comcast.com
@rhegde114
Description: Monitor DHCP packet in packet handler and
614a658 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
Reason for change: Improvement to disassoc hotspot client
                   when dhcp has not assigned ip address
                   within 4 secs

Test Procedure: 1.Connect a client device to the hotspot VAP
                2.Wait for 4 seconds and verify that the client
                  successfully associates with the Access Point
                  (AP) but does not receive a valid IP address
                  from the DHCP server

Risks: None

Signed-off-by: raghavendra.hegde2@comcast.com
@rhegde114
Merge branch 'rdkcentral:develop' into snooper_test
dd84407
anoopchelakkode
anoopchelakkode reviewed Feb 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@anoopchelakkode anoopchelakkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please confirm what are the test cases executed and planned for this feature? Test procedure, both regression and progression should be documented as this is a feature request.

@rhegde114
Copy link
Copy Markdown
Author

rhegde114 commented Feb 9, 2026

Hi Anoop,
Unit testing and basic regression testing have been done after the code changes. QA needs to perform end-to-end testing after the code merge. Test procedure details mentioned in ticket.https://jira.rdkcentral.com/jira/browse/RDKBDEV-3336. Please let me know if more information is needed.
Thanks

bunnam988
bunnam988 reviewed Feb 12, 2026
View reviewed changes
rdkcmf-jenkins
rdkcmf-jenkins reviewed Feb 24, 2026
View reviewed changes
@rhegde114
Description: Monitor DHCP packet in packet handler and
39bd424 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
rdkcmf-jenkins
rdkcmf-jenkins reviewed Feb 25, 2026
View reviewed changes
@rhegde114
Description: Monitor DHCP packet in packet handler and
03dc052 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
rdkcmf-jenkins
rdkcmf-jenkins reviewed Feb 25, 2026
View reviewed changes
@rhegde114
Description: Monitor DHCP packet in packet handler and
c657715 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
@rhegde114
Description: Monitor DHCP packet in packet handler and
6042489 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
@AkhilaReddyK7 AkhilaReddyK7 added the community-contribution Contribution from community label Mar 17, 2026
@narendradandu narendradandu mentioned this pull request Mar 27, 2026
Open
bunnam988
bunnam988 reviewed Apr 2, 2026
View reviewed changes
source/hotspotfd/dhcpsnooper.c
return -1;
}
snoop_AddClientListEntry(gRemote_id, gCircuit_id, "ACK", ipv4_addr, l_cHostName, 0);
snoop_AddClientListEntry(gRemote_id, gCircuit_id, "ACK", ipv4_addr, l_cHostName, 0,0);
Copy link
Copy Markdown
Contributor

@bunnam988 bunnam988 Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that vap_index is being passed as 0 here unconditionally. When this entry is later picked up by constructCommand() to build the deauth string sent to OneWifi, it would always report VAP index 0, regardless of which VAP the client is actually on.

Copy link
Copy Markdown
Author

@rhegde114 rhegde114 Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call happens inside the DHCP ACK processing path (server-to-client direction). At this point, the code only has information extracted from the DHCP packet itself (MAC, IP, hostname, circuit ID). The vapIndex is set in updateRssiForClient(), which is called when a client connects. I think sending 0 is fine for VAP Index.

@bunnam988
Copy link
Copy Markdown
Contributor

bunnam988 commented Apr 2, 2026

@rhegde114
Could we add unit tests covering the newly implemented functions and the timer logic ?

rhegde114 added 3 commits April 2, 2026 09:44
@rhegde114
Merge branch 'rdkcentral:develop' into snooper_test
f2c3fbb
@rhegde114
Description: Monitor DHCP packet in packet handler and
53225bd 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
@rhegde114
Description: Monitor DHCP packet in packet handler and
d306f0a 
             publish the client mac if DHCP server has
             not assigned ip address within 4 secs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdkcmf-jenkins rdkcmf-jenkins rdkcmf-jenkins left review comments

@anoopchelakkode anoopchelakkode anoopchelakkode left review comments

@bunnam988 bunnam988 bunnam988 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

community-contribution Contribution from community

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhegde114 @bunnam988 @rdkcmf-jenkins @anoopchelakkode @AkhilaReddyK7