Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 81 additions & 0 deletions .github/ISSUE_TEMPLATE/player_interface_change_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
name: Middleware Player Interface Change Request
description: Change Request for Middleware Player Interface
title: "<JIRA TICKET>:<Ticket Title>"
labels: ["MW Change Request"]
body:
- type: markdown
attributes:
value: |
Change Request for Middleware Player Interface

- type: textarea
id: description
attributes:
label: Description
description: Provide a clear and concise description of the feature or bug ticket
placeholder: Describe the changes you are bringing
validations:
required: true

- type: textarea
id: additional-context
attributes:
label: Additional Context
description: Add any other context, screenshots, or examples about the feature request
placeholder: Any other relevant information
validations:
required: false

- type: textarea
id: dod-checklist
attributes:
label: Definition of Done (DoD)
description: Mark items with [x] and replace the placeholder text on Details lines with actual information.
value: |
Please complete the following Middleware Layer Integration checklist items to ensure all requirements for changes to be merged.

**IMPORTANT:** Do NOT provide any proprietary information including:
- Links to internal Automatics/CI builds
- Links to internal Confluence pages
- Any other Comcast/Sky proprietary or confidential information
- Development Build/Setup Details

Only provide publicly accessible information and links. All proprietary information should be added to JIRA Ticket.

---

- [ ] **Middleware component tags with changelog**
- Details: For instance https://github.com/rdkcentral/hdmicec/blob/1.0.7/CHANGELOG.md. Include all components that need to go together for Builds to work.

- [ ] **Tested on STBs**

- [ ] **Tested on TVs**

- [ ] **Dependent Layer tags (App Layer, OSS, Product, Halif Headers, Vendor Layers)**
- Details: (e.g. https://github.com/rdk-e/meta-image-support/blob/4.1.1/CHANGELOG.md)

- [ ] **Do Widgets Need Publishing**
- Details: (Provide context if widgets are involved)

- [ ] **Copilot review for Components**
- Details: (Any comments on the review)

- [ ] **Component Test**
- Details: Share Testing done as part of components release

- [ ] **Integration Testing**
- Details: Provide details on Integration testing done within Middleware layer

- [ ] **E2E Testing**
- Details: Provide details on end-to-end testing done across all layers

- [ ] **Performance Testing**
- Details: Provide details on performance testing done

- [ ] **Static code analysis/Coverity**
- Details: Share Coverity runs for components affected

- [ ] **Manual Functional Test**

validations:
required: true
5 changes: 3 additions & 2 deletions .github/workflows/L1-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,48 +4,49 @@
pull_request:
branches: [develop, main]
paths: ['**/*.c', '**/*.cpp', '**/*.cc', '**/*.cxx', '**/*.h', '**/*.hpp', '**/*.sh']
workflow_dispatch:

jobs:
execute-unit-tests-on-pr:
name: Runs all unit tests
name: Runs all unit tests - L1
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: native build
run: yes | ./install-middleware.sh -s subtec

# Run L1 tests
- name: Run unit tests with coverage
- name: Run unit tests with coverage - L1
working-directory: ./test/utests
run: ./run.sh -c

# Publish test results
- name: Publish L1 test results
uses: dorny/test-reporter@v1
with:
name: Unit Test Results
path: test/utests/build/ctest-results.xml
reporter: java-junit

# Upload artifact (test/utests/build/ctest-results.xml)
- name: Upload test result file (test/utests)
uses: actions/upload-artifact@v4
with:
name: ctest-results-middleware-utests-${{ github.run_id }}
path: test/utests/build/ctest-results.xml

- name: Upload CombinedCoverage report
if: ${{ !env.ACT }}
uses: actions/upload-artifact@v4
with:
name: CombinedCoverage-report
path: test/utests/build/CombinedCoverage/
if-no-files-found: warn

# Show failure
- name: Show failure details (if any)
# if: failure()
run: tail -n 50 test/utests/build/ctest-results.xml || true

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
Loading