Rebase by adrojaankur · Pull Request #45 · rdkcentral/rdk_logger

adrojaankur · 2026-01-07T03:58:47Z

No description provided.

Co-authored-by: Saranya <saranya_elango@comcast.com> Co-authored-by: nhanasi <navihansi@gmail.com>

Reason for change: Refactor the RDKLogger component in such a way that, 1. The config file debug.ini is only for the override; 2. Must log even if new module not present in debug.ini 3. The config file must say only the specific level; not individual log levels 4. Default loglevel must be based on LOG.RDK.DEFAULT 5. Remove log4crc overrides Test Procedure: Tested and verified Risks: Medium Signed-off-by: dshett549 <DEEPTHICHANDRASHEKAR_SHETTY@comcast.com> Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com> Co-authored-by: Karunakaran A <48997923+karuna2git@users.noreply.github.com>

Release of RDKLogger v2.0.0

Reason for change: Refactor the RDKLogger component in such a way that, 1. The config file debug.ini is only for the override; 2. Must log even if new module not present in debug.ini 3. The config file must say only the specific level; not individual log levels 4. Default loglevel must be based on LOG.RDK.DEFAULT 5. Remove log4crc overrides Test Procedure: Tested and verified Risks: Medium Signed-off-by: dshett549 <DEEPTHICHANDRASHEKAR_SHETTY@comcast.com> Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com> Co-authored-by: Karunakaran A <48997923+karuna2git@users.noreply.github.com>

Release of RDKLogger v2.0.0

* RDKB-60970: RDKLogger OpenSource Migration Reason for change: To fix compilation errors Test Procedure: Tested and verified Risks:Medium Priority:P1 Signed-off-by: dshett549 <DEEPTHICHANDRASHEKAR_SHETTY@comcast.com> Signed-off-by: karunakaran_amirthalingam <karunakaran_amirthalingam@cable.comcast.com>

Release of RDKLogger v2.1.0

* RDKB-60970: RDKLogger OpenSource Migration Reason for change: To fix compilation errors Test Procedure: Tested and verified Risks:Medium Priority:P1 Signed-off-by: dshett549 <DEEPTHICHANDRASHEKAR_SHETTY@comcast.com> Signed-off-by: karunakaran_amirthalingam <karunakaran_amirthalingam@cable.comcast.com>

Release of RDKLogger v2.1.0

* Add new API to convert string log_level to type rdk_logLevel * Resolve warnings from code * Update rdk_dynamic_logger.c --------- Signed-off-by: dshett549 <DEEPTHICHANDRASHEKAR_SHETTY@comcast.com> Signed-off-by: Karunakaran A <Karunakaran_Amirthalingam@cable.comcast.com>

Release of v2.2.0 Signed-off-by: kamirt573_comcast <karunakaran_amirthalingam@cable.comcast.com>

Reason for change: Add rdk_dbg_* APIs for Backward Compatibility Test Procedure: Verify WiFi Motion Risks: Low Signed-off-by: dshett549 DEEPTHICHANDRASHEKAR_SHETTY@comcast.com Co-authored-by: Deepthi C Shetty <115452109+dshett549@users.noreply.github.com>

* Updated the documentation Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Reason for change: Add rdk_dbg_* APIs for Backward Compatibility Test Procedure: Verify WiFi Motion Risks: Low Signed-off-by: dshett549 DEEPTHICHANDRASHEKAR_SHETTY@comcast.com Co-authored-by: Deepthi C Shetty <115452109+dshett549@users.noreply.github.com>

* Updated the documentation Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Release of v2.3.0 Signed-off-by: kamirt573_comcast <karunakaran_amirthalingam@cable.comcast.com>

Deploy cla action

Deploy fossid_integration_stateless_diffscan_target_repo action

Reason for change: Post Code Coverage in the PR workflow Test Procedure: Tested and verified Risks: Low Signed-off-by: Rose Mary Benny RoseMary_Benny@comcast.com

Reason for change: for optimization Test Procedure: Tested and verified Risks:Medium Priority:P1

Update CODEOWNERS

* Rename rdk_logger_milestone.cpp to rdk_logger_milestone.c

* RDKEMW-6710 : RDKLogger - Improve L1 Test coverage Reason for change: RDKLogger - Improve L1 Test coverage Test Procedure: Tested and verified Risks: Low Signed-off-by: RoseMary_Benny@comcast.com <RoseMary_Benny@comcast.com>

…ded (#28)" This reverts commit a0e2418.

Signed-off-by: kamirt573_comcast <karunakaran_amirthalingam@cable.comcast.com>

…he PR as Comment (#37) * RDKEMW-9545 : Post Code Current Coverage & the latest in the PR as Comment Reason for change: Post Code Current Coverage & the latest in the PR as Comment Test Procedure: Tested and verified Risks: Low Signed-off-by: RoseMary_Benny@comcast.com <RoseMary_Benny@comcast.com>

…est in t…" (#38) This reverts commit cb6e345.

… output type (#41) * RDKEMW-10792: Extending logger_init function to set level, format and output type Reason for change: Extending logger_init function to set level, format and output type Risks:Medium Priority:P1 Signed-off-by: dshett549 <DEEPTHICHANDRASHEKAR_SHETTY@comcast.com> Co-authored-by: Karunakaran A <48997923+karuna2git@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Reason for change: 1. Added support for syslog 2. Added support for systemd_journal 3. Added explicit support for file capture 4. Added different formatting capability 5. Added Dynamic re-configuration of format, output handler Risks:Medium Priority:P1 Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Reason for change: To support legacy systems that uses AUTOREV - Added milestone log location - Added `comcast_dated` format Risks:Medium Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Reason for change: To support legacy systems that uses AUTOREV - Added milestone log location - Added `comcast_dated` format - Added legacy MACRO Risks:Medium Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Copilot

Pull request overview

This pull request performs a significant refactoring of the RDK Logger library, modernizing the codebase and improving its architecture.

Changes:

Refactored logging infrastructure to use log4c more effectively with improved category management and thread safety
Added extensive unit test coverage including rotation, performance, error handling, and configuration tests
Removed deprecated dynamic logger test and simplified build configuration

Reviewed changes

Copilot reviewed 70 out of 70 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
utils/rdklogctrl.c	Fixed spelling error "Reciever" → "Receiver", simplified log level validation, removed obsolete module validation
utils/rdk_logger_onboard_main.c	Simplified onboard logging by removing intermediate buffer and passing format string directly
utils/Makefile.am	Updated build flags, added LOG4C_LIBS, changed all programs to use += operator, fixed library paths
unittests/*	Added comprehensive test suites for ext_init, rotation, performance, error handling, and configuration
src/rdk_logger_init.c	Major refactor with thread safety (pthread mutex), constructor initialization, and ext_init support
src/rdk_debug_priv.c	Complete rewrite of logging infrastructure with new layout/appender system and improved formatting
src/rdk_dynamic_logger.c	Simplified dynamic logging with removal of negation support and cleaner log level handling
src/rdk_debug.c	Simplified public API, removed complex module number tracking, added level_from_string converter
test/*	Removed deprecated dynamic logger test, updated test program with new ext_init API usage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T03:51:39Z

build_dependencies.sh

+wget https://sourceforge.net/projects/log4c/files/log4c/1.2.3/log4c-1.2.3.tar.gz
+tar -xzf log4c-1.2.3.tar.gz
+cd "log4c-1.2.3"
+./configure "--prefix=${INSTALL_PREFIX}"
+make
+make install


This build script downloads and executes third-party source code (log4c-1.2.3.tar.gz from SourceForge) without any integrity verification, which exposes the CI/build environment to a supply-chain attack if the remote artifact or distribution channel is compromised. An attacker who can tamper with that tarball could gain code execution in your build environment (with access to build secrets and artifacts) when ./configure, make, and make install are run. To mitigate this, pin the dependency to a specific immutable artifact and verify its integrity before building (for example, by checking a known-good cryptographic hash or signature) instead of trusting the remote download implicitly.

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

…54) Reason for change: 1. Removed Log split & truncation 2. Configured default buffer size to be 0 as same as Previous Releases 3. Added new log formats as TID & TS_TIDs 4. Added testApp to measure CPU 5. Updated default logging to console instead of recently changes syslog 6. Added unit test cases to verify the new formats 7. Added unified log function to handle all the log formats Test Procedure: Verify huge data Risks: Medium Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Copilot

Pull request overview

Copilot reviewed 71 out of 71 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Reason for change: Move the log4c init to logger init Test Procedure: Verify logging Risks: Medium Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Copilot

Pull request overview

Copilot reviewed 71 out of 71 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-25T00:37:01Z

src/rdk_logger_init.c

 rdk_Error rdk_logger_deinit()
 {
-    if(isLogInited)
+    pthread_mutex_lock(&gInitMutex);
+    if (isLogInited)
    {
-        //rdk_dbgDeinit();
-        rdk_dyn_log_deInit();
-        //rdk_dbg_priv_DeInit();
-        rdk_logger_env_rem_conf_details();
-        log4c_fini();
-        //isLogInited = 0;
+        rdk_dyn_log_deinit();
    }


rdk_logger_deinit() closes the dynamic logger socket but never resets isLogInited (and doesn't call any logger/log4c deinit). After a deinit(), subsequent rdk_logger_init() calls will be a no-op, leaving dynamic logging disabled and preventing reconfiguration. Either (a) make deinit symmetrical (call rdk_dbg_priv_deinit(), set isLogInited=false, and clean up resources), or (b) if deinit is intentionally a no-op, avoid closing the dynamic logger socket and/or document that deinit does not permit re-init.

Copilot · 2026-02-25T00:37:02Z

docs/QUICK_REFERENCE.md

+// Extended initialization with file logging
+rdk_logger_ext_config_t config = {
+    .fileName = "app.log",
+    .logdir = "/var/log/",
+    .maxSize = 1024*1024,    // 1MB
+    .maxCount = 5            // Keep 5 files
+};
+rdk_logger_ext_init(&config);


The rdk_logger_ext_config_t example here uses fields like .fileName, .logdir, .maxSize, .maxCount that don't exist in the current public struct (it now uses output, format, and pFilePolicy). This example won't compile and will mislead users—please update it to match the actual API.

Copilot · 2026-02-25T00:37:02Z

docs/QUICK_REFERENCE.md

+# Disable specific level (~ prefix)
+rdklogctrl myapp LOG.RDK.NETWORK ~DEBUG


This doc claims rdklogctrl can disable a level using a ~ prefix (e.g. ~DEBUG), but the updated rdklogctrl implementation no longer accepts ~ and will treat it as an invalid log level. Please either restore ~ handling in the tool/protocol or remove/update this documentation.

Suggested change

# Disable specific level (~ prefix)

rdklogctrl myapp LOG.RDK.NETWORK ~DEBUG

# Disable logging for a module (set level to NONE)

rdklogctrl myapp LOG.RDK.NETWORK NONE

Copilot · 2026-02-25T00:37:02Z

unittests/rdkLoggerDynamic.cpp

+            break;
+        case LVL_TEST:
+            strcpy(level_str, "~NONE");
+            break;


This test case uses ~NONE as a log level for rdklogctrl, but rdklogctrl no longer supports ~-prefixed levels. As written, the command will fail (and the test currently ignores the system() return code), so it isn't exercising the intended behavior. Update the test to use supported levels and assert on the command exit status/output (or reintroduce ~ support if it's required).

Copilot · 2026-02-25T00:37:03Z

include/rdk_debug.h

-
-
-#ifndef _RDK_DEBUG_H_
+#ifndef _RDK_DEBUG_H


Header guard macro is inconsistent: #ifndef _RDK_DEBUG_H but #define _RDK_DEBUG_H_. This defeats the include guard and can cause multiple-definition / redefinition issues on repeated includes. Use the same macro name in both directives (and in the closing #endif comment).

Suggested change

#ifndef _RDK_DEBUG_H

#ifndef _RDK_DEBUG_H_

Copilot · 2026-02-25T00:37:03Z

include/rdk_logger.h

+#define RDK_LOGGER_INIT()   (0 == access(DEBUG_INI_OVERRIDE_PATH_1, F_OK))          \
+                                ? rdk_logger_init(DEBUG_INI_OVERRIDE_PATH_1)        \
+                                : (0 == access(DEBUG_INI_OVERRIDE_PATH_2, F_OK))    \
+                                    ? rdk_logger_init(DEBUG_INI_OVERRIDE_PATH_2)    \
+                                    : rdk_logger_init(DEBUG_INI_NAME);


RDK_LOGGER_INIT() macro includes a trailing semicolon, which breaks common usage patterns like if (RDK_LOGGER_INIT() != RDK_SUCCESS) { ... } (as shown in the docs). Define it as a pure expression (no trailing ;) and consider wrapping the whole ternary in parentheses for safe use in larger expressions.

Suggested change

#define RDK_LOGGER_INIT() (0 == access(DEBUG_INI_OVERRIDE_PATH_1, F_OK)) \

? rdk_logger_init(DEBUG_INI_OVERRIDE_PATH_1) \

: (0 == access(DEBUG_INI_OVERRIDE_PATH_2, F_OK)) \

? rdk_logger_init(DEBUG_INI_OVERRIDE_PATH_2) \

: rdk_logger_init(DEBUG_INI_NAME);

#define RDK_LOGGER_INIT() ((0 == access(DEBUG_INI_OVERRIDE_PATH_1, F_OK)) \

? rdk_logger_init(DEBUG_INI_OVERRIDE_PATH_1) \

: ((0 == access(DEBUG_INI_OVERRIDE_PATH_2, F_OK)) \

? rdk_logger_init(DEBUG_INI_OVERRIDE_PATH_2) \

: rdk_logger_init(DEBUG_INI_NAME)))

Copilot · 2026-02-25T00:37:03Z

src/rdk_logger_init.c

+static pthread_mutex_t gInitMutex = PTHREAD_MUTEX_INITIALIZER;
+
+bool isLogInited = false;
+


isLogInited is a non-static global symbol. Since it is only used to protect internal initialization state, keeping it static avoids exporting an unnecessary symbol from the shared library and prevents accidental external linkage/ABI coupling.

rdkcmf-jenkins and others added 30 commits June 24, 2025 15:07

Deploy cla action

06bfdfa

Update debug.ini (#18)

f3f31b1

RDKEMW-4794 : RDM Prints incorrect message for Codebig Path (#13)

e1980c5

Co-authored-by: Saranya <saranya_elango@comcast.com> Co-authored-by: nhanasi <navihansi@gmail.com>

Release of RDKLogger v2.0.0

50bee88

Release of RDKLogger v2.0.0

Release of RDKLogger v2.0.0

0087a47

Release of RDKLogger v2.0.0

Release of RDKLogger v2.1.0

6f16c07

Release of RDKLogger v2.1.0

Release of RDKLogger v2.1.0

a46c1ca

Release of RDKLogger v2.1.0

Release of RDKLogger v2.2.0

28d277a

Release of v2.2.0 Signed-off-by: kamirt573_comcast <karunakaran_amirthalingam@cable.comcast.com>

Release of RDKLogger v2.2.0

5303296

Release of v2.2.0 Signed-off-by: kamirt573_comcast <karunakaran_amirthalingam@cable.comcast.com>

Update Documentation for RDKLogger (#24)

5861164

* Updated the documentation Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Update Documentation for RDKLogger (#24)

35e2f74

* Updated the documentation Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Release of RDKLogger v2.3.0

92065f0

Release of v2.3.0 Signed-off-by: kamirt573_comcast <karunakaran_amirthalingam@cable.comcast.com>

Merge branch 'main' into develop

0cd6dc8

Merge branch 'develop' into feature/action-deploy-for/develop

c28a19c

Deploy cla action

79e134a

Merge pull request #15 from rdkcentral/feature/action-deploy-for/develop

4f23fed

Deploy cla action

Deploy fossid_integration_stateless_diffscan_target_repo action

370c54f

Merge pull request #26 from rdkcentral/feature/actions/develop-fossid

33e6acd

Deploy fossid_integration_stateless_diffscan_target_repo action

RDKEMW-8798 : Post Code Coverage in the PR workflow (#27)

3e2cdb3

Reason for change: Post Code Coverage in the PR workflow Test Procedure: Tested and verified Risks: Low Signed-off-by: Rose Mary Benny RoseMary_Benny@comcast.com

RDKEMW-8528: Remove logMilestone.sh & use the binary when needed (#28)

a0e2418

Reason for change: for optimization Test Procedure: Tested and verified Risks:Medium Priority:P1

Update CODEOWNERS

3d25a4e

Merge pull request #29 from rdkcentral/sbarre01-patch-1

695b825

Update CODEOWNERS

dshett549 and others added 11 commits October 9, 2025 21:20

RDKEMW-9247 : Moving rdklogger_milestone file from .cpp to .c (#30)

3996cb2

* Rename rdk_logger_milestone.cpp to rdk_logger_milestone.c

RDKEMW-6710: RDKLogger - Improve L1 Test coverage (#31)

c9ea7f3

* RDKEMW-6710 : RDKLogger - Improve L1 Test coverage Reason for change: RDKLogger - Improve L1 Test coverage Test Procedure: Tested and verified Risks: Low Signed-off-by: RoseMary_Benny@comcast.com <RoseMary_Benny@comcast.com>

Revert "RDKEMW-8528: Remove logMilestone.sh & use the binary when nee…

5f129d6

…ded (#28)" This reverts commit a0e2418.

Release of v2.4.0

aa09d85

Signed-off-by: kamirt573_comcast <karunakaran_amirthalingam@cable.comcast.com>

Revert "RDKEMW-9545: [RDKLogger] Post Code Current Coverage & the lat…

8457a0a

…est in t…" (#38) This reverts commit cb6e345.

RDKEMW-10792 : Update the Milestone log location

746a547

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

RDKEMW-10792 : Added legacy layout and defined Milestone log location

ea90f87

Reason for change: To support legacy systems that uses AUTOREV - Added milestone log location - Added `comcast_dated` format Risks:Medium Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Copilot AI review requested due to automatic review settings January 14, 2026 03:48

Copilot started reviewing on behalf of karuna2git January 14, 2026 03:49 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

karuna2git and others added 2 commits January 13, 2026 22:56

Release of v3.0.0

cbdb411

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Copilot AI review requested due to automatic review settings February 24, 2026 14:41

Copilot started reviewing on behalf of karuna2git February 24, 2026 14:42 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

karuna2git and others added 2 commits February 24, 2026 17:30

RDKEMW-14300 : Move the log4c init to logger init (#55)

b9d5106

Reason for change: Move the log4c init to logger init Test Procedure: Verify logging Risks: Medium Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Release of v3.1.0

f7d65e4

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Copilot AI review requested due to automatic review settings February 25, 2026 00:30

Copilot started reviewing on behalf of karuna2git February 25, 2026 00:31 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase#45

Rebase#45
adrojaankur wants to merge 45 commits intosupport/1.1.0from
develop

adrojaankur commented Jan 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Copilot AI Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

		# Disable specific level (~ prefix)
		rdklogctrl myapp LOG.RDK.NETWORK ~DEBUG

		static pthread_mutex_t gInitMutex = PTHREAD_MUTEX_INITIALIZER;

		bool isLogInited = false;

Conversation

adrojaankur commented Jan 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants