Skip to content

Conversation

@nhanasi
Copy link
Contributor

@nhanasi nhanasi commented Jan 23, 2026

  • Move BT mac address fetch to generic script
  • Use Vendor script only available to read BT mac

@nhanasi nhanasi requested a review from a team as a code owner January 23, 2026 17:04
Copilot AI review requested due to automatic review settings January 23, 2026 17:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors how the Bluetooth MAC address is obtained by moving the core retrieval logic into a generic script and making getDeviceDetails.sh delegate to either a vendor-specific or generic implementation. It aligns the Bluetooth MAC flow with the pattern of using vendor overrides where available.

Changes:

  • Introduced readBTAddress-generic.sh to encapsulate the default logic for reading the Bluetooth MAC address using getDeviceBluetoothMac.
  • Updated getBluetoothMac() in getDeviceDetails.sh to source a vendor-specific script when available, otherwise fall back to the new generic script.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lib/rdk/readBTAddress-generic.sh New generic implementation for computing bluetooth_mac, sourcing common properties and utilities.
lib/rdk/getDeviceDetails.sh Updated getBluetoothMac() to delegate to vendor or generic Bluetooth MAC scripts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 23, 2026 17:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 23, 2026 17:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nhanasi
Copy link
Contributor Author

nhanasi commented Jan 23, 2026

@nhanasi nhanasi merged commit f8b2432 into develop Jan 28, 2026
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants