-
Notifications
You must be signed in to change notification settings - Fork 5
RDKEMW-12562 : Move Bluetooth Mac update from Device Details to Bluetooth Service #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nhanasi
commented
Jan 23, 2026
- Move BT mac address fetch to generic script
- Use Vendor script only available to read BT mac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors how the Bluetooth MAC address is obtained by moving the core retrieval logic into a generic script and making getDeviceDetails.sh delegate to either a vendor-specific or generic implementation. It aligns the Bluetooth MAC flow with the pattern of using vendor overrides where available.
Changes:
- Introduced
readBTAddress-generic.shto encapsulate the default logic for reading the Bluetooth MAC address usinggetDeviceBluetoothMac. - Updated
getBluetoothMac()ingetDeviceDetails.shto source a vendor-specific script when available, otherwise fall back to the new generic script.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/rdk/readBTAddress-generic.sh | New generic implementation for computing bluetooth_mac, sourcing common properties and utilities. |
| lib/rdk/getDeviceDetails.sh | Updated getBluetoothMac() to delegate to vendor or generic Bluetooth MAC scripts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@shibu-kv Addressed comments and added the results in |