RDKB-63810: Adding support for DHCP Release when DHCPManager is enabled#197
Open
aadhithan01 wants to merge 2 commits intordkcentral:mainfrom
Open
RDKB-63810: Adding support for DHCP Release when DHCPManager is enabled#197aadhithan01 wants to merge 2 commits intordkcentral:mainfrom
aadhithan01 wants to merge 2 commits intordkcentral:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds DHCP release support for DHCPManager-backed DHCPv4/v6 client stop flows so releases are only triggered when explicitly requested, avoiding release packets during FR/WAN refresh scenarios.
Changes:
- Update DHCPManager stop logic to set
<iface>.X_RDK_Release=truewhen a release is requested. - Retain
<iface>.Enable=falsebehavior when stopping without release.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
S-Parthiban-Selvaraj
approved these changes
Mar 30, 2026
hpatel006c
approved these changes
Mar 31, 2026
LakshminarayananShenbagaraj
approved these changes
Apr 1, 2026
guto86
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKB-63810: CPE is sending DHCPv4/6 Releases in every FR/WAN refresh
Reason for change: CPE shouldn't send DHCPv4/6 Releases in every FR/WAN refresh
Test Procedure: provided Below
Risks: Low
Test the DHCPv6 RDKRelease(Device.DHCPv6.Client.1.X_RDK_Release) and collect the dibbler log and dhcpmanager log, also check DHPCManager sending release msg to wanmanager - Done
Test the DHCPv4 RDKRelease((Device.DHCPv4.Client.1.X_RDK_Release) ) and collect the udhcpc log and dhcpmaanger log, also check DHPCManager sending release msg to wanmanager - DONE
Test the RDK restart for DHCPv4(Device.DHCPv4.Client.1.X_RDK_Restart) and collect the udhcpc log and dhcpmaanger log
Test the RDK restart for DHCPv6 (Device.DHCPv6.Client.1.X_RDK_Restart) and collect the udhcpc log and dhcpmaanger log
Do Disable/Enable and check whether DHCPv4 and DHCPv6 release msg sent to WANMANAGER
(Device.DHCPv6.Client.1.Enable bool false), (Device.DHCPv6.Client.1.Enable bool true)
kill the udhcpc and dibbler-client with sigTERM(kill -TERM) and check whether DHCPv4 and DHCPv6 release msg sent to WANMANAGER