Skip to content

RDKEMW-12059: Fix Coverity identified issues#192

Merged
apatel859 merged 5 commits intodevelopfrom
topic/RDKEMW-12059-coverity-suppress
Mar 27, 2026
Merged

RDKEMW-12059: Fix Coverity identified issues#192
apatel859 merged 5 commits intodevelopfrom
topic/RDKEMW-12059-coverity-suppress

Conversation

@dkumar798
Copy link
Copy Markdown

Reason for Change: Suppressed the Coverity identified issues
Risks: Low
Priority: P2
Signed-off-by:Dineshkumar P [dinesh_kumar2@comcast.com]

@dkumar798 dkumar798 requested a review from a team as a code owner March 25, 2026 10:00
Copilot AI review requested due to automatic review settings March 25, 2026 10:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses static-analysis (Coverity) findings across the GDial server by adding targeted suppressions and small code adjustments to reduce false positives and flagged patterns.

Changes:

  • Add error-check logging around app-cache erase operations.
  • Add Coverity suppression annotations for specific reported issues (printf args, deadcode, url manipulation, parameter hidden).
  • Remove a redundant pointer nullification in the unit-test executable.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
server/plat/gdialappcache.cpp Adds an erase() return-code check/logging before inserting into the cache.
server/plat/gdial-plat-util.c Adds a Coverity suppression for a printf_args report in logging.
server/gdialserver_ut.cpp Removes a redundant testObject = nullptr; assignment after delete.
server/gdial-rest.c Adds Coverity suppressions around dead-code paths and origin validation checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 27, 2026 10:01
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 27, 2026 11:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@apatel859 apatel859 merged commit 6500318 into develop Mar 27, 2026
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants