fix(demo): make demo tests pass and run them in CI - #7
Merged
Conversation
The docs-page.component.spec.ts imported a non-existent `HealthPage` class (renamed to `DocsPage`), which broke TypeScript compilation and aborted the whole karma run. Fix the spec and add a demo test step to the Lint workflow so this stays green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SC7MC8G2HgnXqR4rXr2ESN
✅ Deploy Preview for ionic-theme-md3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Playwright test results
Details
|
Contributor
|
📊 Playwright Test Report View the detailed test report: https://rdlabo-team.github.io/ionic-theme-md3/pr-7/ |
The demo resolves @rdlabo/ionic-theme-md3 via `file:..` (a symlink to the repo root), whose built dist/ and peer deps (@ionic/core, @stencil/core) live in the root node_modules. dist/ is gitignored, so CI must run root `npm ci` + `npm run build` before the demo can compile. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SC7MC8G2HgnXqR4rXr2ESN
Contributor
|
📊 Playwright Test Report View the detailed test report: https://rdlabo-team.github.io/ionic-theme-md3/pr-7/ |
Switch the demo to Angular 21's @angular/build:unit-test builder (Vitest runner, jsdom) so tests run in Node without a real browser. Replace the Jasmine spy APIs in the mocks with Vitest equivalents, add a vitest config that inlines the Ionic ESM packages, and drop the browser flag from CI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SC7MC8G2HgnXqR4rXr2ESN
Contributor
|
📊 Playwright Test Report View the detailed test report: https://rdlabo-team.github.io/ionic-theme-md3/pr-7/ |
- Pin @playwright/test from ^1.57.0 to exact 1.58.2 - Update docker script references from v1.56.0-noble to v1.58.2-noble - Update package-lock.json (was resolving to 1.61.0) Co-Authored-By: rdlabo <sakakibara@rdlabo.jp>
Contributor
|
📊 Playwright Test Report View the detailed test report: https://rdlabo-team.github.io/ionic-theme-md3/pr-7/ |
Align the demo's non-@rdlabo ESLint setup to the fleet standard and unify dependency versions. Selector rules stay off (demo), no class-suffix / prefer-on-push added. - remove deprecated @rdlabo/rules/deny-constructor-di - complete the winecode off-rule set (no-empty-object-type, no-async-promise-executor, no-prototype-builtins, no-irregular-whitespace, no-unexpected-multiline) - versions: eslint ^9.39.4, @eslint/js ^9.39.4, typescript-eslint ^8.61.1, angular-eslint 21.4.0, @rdlabo/eslint-plugin-rules ^21.0.0 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ch5Dua6sbthgLJSbPAAENF
Contributor
|
📊 Playwright Test Report View the detailed test report: https://rdlabo-team.github.io/ionic-theme-md3/pr-7/ |
Regenerate the lockfile so `npm ci` matches package.json (CI was failing on missing chokidar@4/readdirp@4 entries). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ch5Dua6sbthgLJSbPAAENF
Contributor
|
📊 Playwright Test Report View the detailed test report: https://rdlabo-team.github.io/ionic-theme-md3/pr-7/ |
The lockfile is generated with npm 11.7 (node 24 latest); pinning CI to node 24.11.1 (npm 11.6.x) made `npm ci` reject it (Missing readdirp@4.1.2). Use node 24 (latest 24.x) so CI npm matches the committed lock. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ch5Dua6sbthgLJSbPAAENF
Contributor
|
📊 Playwright Test Report View the detailed test report: https://rdlabo-team.github.io/ionic-theme-md3/pr-7/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
demoの Angular ユニットテスト（31 spec）が実行できない状態だったため修正し、CI（Lint workflow）でも実行するようにしました。原因
demo/src/app/docs/docs-page.component.spec.tsが存在しないクラスHealthPageを import していた（実体はDocsPageにリネーム済み）。このため TypeScript コンパイルが失敗し（TS2305）、karma ビルダーがビルドごと中断して 31 spec が1件も実行できませんでした。変更
docs-page.component.spec.tsのHealthPageをDocsPageに修正.github/workflows/lint.ymlのlintジョブにnpm test -- --watch=false --browsers=ChromeHeadlessを追加確認
Executed 31 of 31 SUCCESS🤖 Generated with Claude Code