Skip to content

use GH library entries file for CI validations #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Simek merged 1 commit into from
May 15, 2026
+12 −32
Merged

use GH library entries file for CI validations #2462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { fetch } from 'bun';

import { type LibraryType } from '~/types';
import { type LibraryDataEntryType, type LibraryType } from '~/types';

export const REQUEST_SLEEP = 5000;

Expand Down Expand Up @@ -55,7 +55,7 @@ export function sleep(ms = 0, msMax?: number) {
);
}

export function fillNpmName(library: LibraryType) {
export function fillNpmName<T extends LibraryType | LibraryDataEntryType>(library: T): T {
if (!library.npmPkg) {
const parts = library.githubUrl.split('/');
library.npmPkg = parts[parts.length - 1].toLowerCase();
Expand Down
40 changes: 10 additions & 30 deletions scripts/validate-new-entries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { fetch } from 'bun';
import { differenceWith } from 'es-toolkit/array';
import { isEqual } from 'es-toolkit/compat';

import { type LibraryDataEntryType, type LibraryType } from '~/types';
import { type LibraryDataEntryType } from '~/types';
import { VALID_ENTRY_KEYS } from '~/util/Constants';

import libraries from '../react-native-libraries.json';
Expand All @@ -19,6 +19,7 @@ async function makeBaseFileQuery() {
}

const mainData = await makeBaseFileQuery();
const mainDataWithNpmPkg = mainData.map(fillNpmName);
const modifiedEntries = differenceWith(libraries, mainData, isEqual);

if (modifiedEntries.length === 0) {
Expand Down Expand Up @@ -108,24 +109,16 @@ for (let i = 0; i < modifiedEntries.length; i += BATCH_SIZE) {

if (mainData.some(({ githubUrl }) => githubUrl === entryWithNpmData.githubUrl)) {
if (entryWithGitHubData?.alternatives && entryWithGitHubData.alternatives.length > 0) {
const existingEntryResponse = await fetch(
`https://reactnative.directory/api/library?name=${entryWithGitHubData.npmPkg}`
const existingEntry = mainDataWithNpmPkg.find(
lib => lib.npmPkg === entryWithGitHubData.npmPkg
);

if (existingEntryResponse.status !== 200) {
console.error('Cannot fetch the modified library data from the directory.');
if (!existingEntry) {
console.error(`Cannot set alternatives for the package not listed in the directory.`);
return false;
}

const existingEntryJson = (await existingEntryResponse.json()) as Record<
string,
LibraryType
>;

if (
!existingEntryJson[entryWithGitHubData.npmPkg].unmaintained &&
existingEntryJson[entryWithGitHubData.npmPkg].newArchitecture !== false
) {
if (!existingEntry.unmaintained && existingEntry.newArchitecture !== false) {
console.error(
`Cannot set alternatives for the ${entryWithGitHubData.npmPkg} package which is not marked as unmaintained or not supporting New Architecture.`
);
Expand All @@ -135,23 +128,10 @@ for (let i = 0; i < modifiedEntries.length; i += BATCH_SIZE) {
}

if (entryWithGitHubData?.alternatives && entryWithGitHubData.alternatives.length > 0) {
const alternativesDataResponse = await fetch(
`https://reactnative.directory/api/library?name=${entryWithGitHubData.alternatives.join(',')}`
);

if (alternativesDataResponse.status !== 200) {
console.error('Cannot check the alternative library existence in the directory.');
return false;
}

const alternativesDataJson = (await alternativesDataResponse.json()) as Record<
string,
LibraryType
>;

const alternativesChecks = entryWithGitHubData.alternatives.map(alternative => {
if (alternative in alternativesDataJson) {
if (alternativesDataJson[alternative].unmaintained) {
const alternativeEntry = mainDataWithNpmPkg.find(lib => lib.npmPkg === alternative);
if (alternativeEntry) {
if (alternativeEntry.unmaintained) {
console.error(
`${alternative} is marked as unmaintained in the directory, so it cannot be defined as an alternative for the package.`
);
Expand Down