CODEOWNERS: Activate hard and soft gates (#632)#703
Open
adamkudrna wants to merge 1 commit intomasterfrom
Open
CODEOWNERS: Activate hard and soft gates (#632)#703adamkudrna wants to merge 1 commit intomasterfrom
adamkudrna wants to merge 1 commit intomasterfrom
Conversation
Moves CODEOWNERS from the repo root to .github/ and replaces the fully-commented-out file with an active configuration using @react-ui-org/maintainers as the default team.
adamkudrna
force-pushed
the
maintenance/codeowners-take-2
branch
from
beac5b8 to
2535ed9
Compare
adamkudrna
changed the title
mbohal
requested changes
Mar 26, 2026
| /.eslintrc @bedrich-schindler @mbohal | ||
|
|
||
| # Styles & style tooling | ||
| /src/theme.scss @adamkudrna |
Contributor
There was a problem hiding this comment.
I don' t think we can depend on a single person ever. Last time @adamkudrna went for a vacation and we needed the merge critically.
As it is, sooner or later this will lead to disabling the codeowners functionality again.
Would you consider changing the hard gates to soft gates?
(Honestly I don't think we really need it at all in a team so small)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
CODEOWNERSfrom the repo root to.github/(the preferred location) and replaces the fully-commented-out file with an active configuration.Strategy
@react-ui-org/maintainerscovers everything not explicitly listed — any team member can review.@bedrich-schindleror@mbohal; style tooling require@adamkudrna. No team fallback, so these files cannot be merged without the named reviewer.*.md, andsrc/styles/notify@adamkudrnabut any maintainer can approve.The broad per-extension rules (
*.js,*.scss) from the original are intentionally omitted. The original config was also broken due to the non-existent@developersteam, which should have been@react-ui-org/developers— since replaced by @react-ui-org/maintainers.Also removes
CODEOWNERSfrom.npmignoresince it no longer exists at the root.Closes #632