Remove deprecated default exports from public entry points (#1759)#1759
Open
robhogan wants to merge 1 commit into
Open
Remove deprecated default exports from public entry points (#1759)#1759robhogan wants to merge 1 commit into
robhogan wants to merge 1 commit into
Conversation
Contributor
|
@robhogan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110062342. |
Summary:
Remove the deprecated default-object export from Metro packages. The supported public API is now exclusively named exports, so any consumer importing a Metro package's default - directly, or implicitly via Babel/TypeScript `esModuleInterop` - will break and must migrate to named imports.
This affects the public entry points of `metro`, `metro-config`, `metro-cache`, `metro-core`, `metro-resolver`, `metro-source-map`, `metro-babel-transformer`, and `metro-transform-worker`.
Default imports like these will no longer work:
```js
import metro from 'metro';
metro.runServer(config);
import metroConfig from 'metro-config';
const config = await metroConfig.loadConfig();
```
```js
const metro = require('metro').default;
metro.runBuild(config, options);
```
Switch to named imports instead:
```js
import {runServer, runBuild} from 'metro';
import {loadConfig, mergeConfig} from 'metro-config';
runServer(config);
```
```js
const {runBuild} = require('metro');
runBuild(config, options);
```
Namespace imports are unaffected and continue to work, since they bind the package's named exports:
```js
import * as metro from 'metro';
metro.runServer(config);
```
Changelog: [Breaking] Removed the deprecated default export from Metro's public packages; use named (or namespace) imports instead.
___
Reviewed By: huntie
Differential Revision: D110062342
769a7f1 to
68affd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove the deprecated default-object export from Metro packages. The supported public API is now exclusively named exports, so any consumer importing a Metro package's default - directly, or implicitly via Babel/TypeScript
esModuleInterop- will break and must migrate to named imports.This affects the public entry points of
metro,metro-config,metro-cache,metro-core,metro-resolver,metro-source-map,metro-babel-transformer, andmetro-transform-worker.Default imports like these will no longer work:
Switch to named imports instead:
Namespace imports are unaffected and continue to work, since they bind the package's named exports:
Changelog: [Breaking] Removed the deprecated default export from Metro's public packages; use named (or namespace) imports instead.
Reviewed By: huntie
Differential Revision: D110062342