Skip to content

Commit 3ad0b82

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Throw if getCatalystInstance() is executed when running on bridgless mode + legacy arch minification (#51112)
Summary: Pull Request resolved: #51112 Throw if getCatalystInstance() is executed when running on bridgless mode + legacy arch minification This should be safe given that all the methods of BridgelessCatalystInstance throw exceptions changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D74200099 fbshipit-source-id: a888061250f19348a22895c3684aa2333280c916
1 parent a02052d commit 3ad0b82

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/BridgelessReactContext.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import com.facebook.react.bridge.UIManager
2424
import com.facebook.react.bridge.WritableNativeArray
2525
import com.facebook.react.common.annotations.FrameworkAPI
2626
import com.facebook.react.common.annotations.UnstableReactNativeAPI
27+
import com.facebook.react.common.build.ReactBuildConfig
2728
import com.facebook.react.devsupport.interfaces.DevSupportManager
2829
import com.facebook.react.internal.featureflags.ReactNativeNewArchitectureFeatureFlags
2930
import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler
@@ -63,6 +64,10 @@ internal class BridgelessReactContext(context: Context, private val reactHost: R
6364
override fun getFabricUIManager(): UIManager? = reactHost.uiManager
6465

6566
override fun getCatalystInstance(): CatalystInstance {
67+
if (ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE) {
68+
throw UnsupportedOperationException(
69+
"CatalystInstance is not supported when Bridgeless mode is enabled.")
70+
}
6671
Log.w(
6772
TAG,
6873
"[WARNING] Bridgeless doesn't support CatalystInstance. Accessing an API that's not part of" +

0 commit comments

Comments
 (0)