Implement saved window positioning per target#53743
Closed
huntie wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82236159 |
huntie
force-pushed
the
export-D82236159
branch
from
4d7576c to
a70d1fe
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82236159 |
huntie
force-pushed
the
export-D82236159
branch
from
a70d1fe to
4c5aea6
Compare
Contributor
huntie
force-pushed
the
export-D82236159
branch
from
4c5aea6 to
18367fe
Compare
Contributor
huntie
force-pushed
the
export-D82236159
branch
from
18367fe to
76d363d
Compare
Contributor
Summary: As titled. A long awaited quality of life improvement that we can now deliver with our desktop shell. Window arrangements are saved per [`windowKey`](https://github.com/facebook/react-native/blob/da7bf9c54567aae62ff355b79e66f511cb382065/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js#L193), mapping to each previously opened debugger target. **Limitations** - Does not save/restore macOS fullscreen app state. Changelog: [Internal] Reviewed By: vzaidman Differential Revision: D82236159
huntie
force-pushed
the
export-D82236159
branch
from
76d363d to
213660e
Compare
Contributor
Contributor
|
This pull request has been merged in 136d795. |
Collaborator
|
This pull request was successfully merged by @huntie in 136d795 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. A long awaited quality of life improvement that we can now deliver with our desktop shell.
Window arrangements are saved per
windowKey, mapping to each previously opened debugger target.Limitations
Changelog: [Internal]
Rollback Plan:
Differential Revision: D82236159