Skip to content

fix: add line break to gradle.properties for template testing#57107

Closed
hurali97 wants to merge 1 commit into
react:mainfrom
hurali97:fix/add-line-space
Closed

fix: add line break to gradle.properties for template testing#57107
hurali97 wants to merge 1 commit into
react:mainfrom
hurali97:fix/add-line-space

Conversation

@hurali97

@hurali97 hurali97 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary:

This fixes the failing CI jobs on main for template testing. The job fails as they echo react.internal.mavenLocalRepo=... to the gradle.properties of template test project. As a result of which the gradle.properties look like below:

android.builtInKotlin=false
android.newDsl=falsereact.internal.mavenLocalRepo=...

To fix it we add a line break in the echo command.

Changelog:

[INTERNAL] [FIXED] - add line break to gradle.properties for template testing

Test Plan:

  • CI Passing
  • Verified Locally

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 8, 2026
@hurali97

hurali97 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

cc: @cortinico - This fixes the failing CI jobs on main for template testing.

As an alternative, we can add a line break directly in the android/gradle.properties in community/template. Let me know what you prefer.

@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jun 8, 2026
@meta-codesync

meta-codesync Bot commented Jun 8, 2026

Copy link
Copy Markdown

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D107880136.

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync Bot closed this in b392035 Jun 8, 2026
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @hurali97 in b392035

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 8, 2026
@meta-codesync

meta-codesync Bot commented Jun 8, 2026

Copy link
Copy Markdown

@cipolleschi merged this pull request in b392035.

@cortinico

Copy link
Copy Markdown
Contributor

This did not work @hurali97

CI is still broken on main with:

* What went wrong:
A problem occurred evaluating project ':app'.
> Failed to apply plugin 'com.android.internal.application'.
   > Cannot parse project property android.newDsl='false
     react.internal.mavenLocalRepo=/tmp/react-native-tmp/maven-local' of type 'class java.lang.String' as boolean. Expected 'true' or 'false'.

@hurali97

hurali97 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Strange, Let me take care of this tomorrow!

@hurali97

hurali97 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Added here - #57114

Let's wait for the CI jobs to be finished, so we are sure this works 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants