Keep FileReader in DONE state after abort#57692
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
fallintoplace
force-pushed
the
fix-filereader-abort-state
branch
from
July 25, 2026 20:26
beb7b66 to
71067af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Before #57375, reads never entered
LOADING, so the active abort path was effectively unreachable. Now that reads useLOADING, that path calls_reset()before and after transitioning toDONE, leaving the reader inEMPTYafterabort()returns.This differs from the File API abort algorithm, which keeps an active reader in
DONE. The final reset also overwrites a replacement read started by anaborthandler, and that new read clears the shared_abortedflag before the canceled native promise settles.This change:
DONEwith a null resultloadendif the abort handler starts another readChangelog:
[GENERAL] [FIXED] - Keep
FileReaderin the correct state after aborting a read.Test Plan:
yarn jest packages/react-native/Libraries/Blob/__tests__/FileReader-test.js --runInBand./node_modules/.bin/prettier --check packages/react-native/Libraries/Blob/FileReader.js packages/react-native/Libraries/Blob/__tests__/FileReader-test.js./node_modules/.bin/eslint --max-warnings 0 packages/react-native/Libraries/Blob/FileReader.js packages/react-native/Libraries/Blob/__tests__/FileReader-test.jsyarn flow-check