guard shrink-factor division against floating-point near-zero#1974
Open
harsha-cpp wants to merge 2 commits into
Open
guard shrink-factor division against floating-point near-zero#1974harsha-cpp wants to merge 2 commits into
harsha-cpp wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cipolleschi
approved these changes
Jun 9, 2026
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Nicely spotted! Thanks for the fix
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D108030908. |
Contributor
Author
|
thanks @cipolleschi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1665.
problem: when all flex children are frozen to their min-width in the first
pass,
totalFlexShrinkScaledFactorsis reduced to near-zero by floating-pointcancellation rather than exactly 0. the guard in
distributeFreeSpaceSecondPassuses exact equality (
== 0), so it never fires, and the second pass dividesremainingFreeSpaceby a value on the order of 1e-7, producing a childSize onthe order of 1e11 that overwhelms the min/max clamp.
fix: replace the exact-zero check with a relative epsilon guard
(
shrinkFactorMagnitude < 1e-6f). when the magnitude is that small, all itemswere already frozen in the first pass; the safe fallback (
childFlexBasis + flexShrinkScaledFactor) applies and the subsequentboundAxisWithAutoMinclampscorrectly to minWidth.
regression:
YGFlexShrinkBorderBug.flex_basis_0_border_minwidth_rowreproducesthe original crash — 4 children,
borderWidthdifference of 1e-6 across them,all now compute to their correct minWidth.