You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ZakiFan Thanks for your PR. It sounds good. However, there are several suggesstions for you as follows
There are four kinds of service method (Unary RPC, Server streaming RPC, Client streaming RPC and Bidirectional streaming RPC). Now, HelloWorld is the Unary RPC, so you'd better divide GrpcServer and GrpcClient to three different kinds of Server streaming RPC, Client streaming RPC and Bidirectional streaming RPC. If you do, it will make others understand better.
Keep the same code style, such as all of ***Server.java and ***Client.java are in the package io.grpc.examples
The rest of three kinds of server method are built by hello_streaming.proto and route_guide.proto, which are the official examples in grpc-java project, so you'd better use these to build the rest of server methods, because official examples can illustrate all features of grpc-java better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
了解了GRPC的使用方式。后面会把GRPC和Netty了解清楚。