feat: migrate hosting packages to ReactiveUI.Primitives#256
Merged
Conversation
Package management and targets: - Add Central Package Management with StyleSharp.Analyzers 3.16.0, ReactiveUI.Primitives 6.0.0, ReactiveUI 24.0.0-beta.3, ReactiveUI.Avalonia 12.1.0-beta.1, and net11 preview package versions. - Expand projects to net11.0 and relevant net11.0 platform TFMs. ReactiveUI.Primitives migration: - Remove direct System.Reactive source and project usage in favor of ReactiveUI.Primitives aliases and APIs. - Update hosted service, platform, plugin, ReactiveUI bridge, and example code for the new primitives surface. Analyzer and quality updates: - Resolve StyleSharp/Roslyn analyzer findings without suppressions and keep project documentation/XML comments aligned. - Convert repository guidance to AGENTS.md and include it in the solution-oriented update. Tests and validation: - Add focused TUnit coverage for plugin loading, hosted service lifecycle, plugin base registration, assembly loading, and single-instance behavior. - Fix the ReactiveAvalonia example result template so searched NuGet packages render in the list.
Seal the NUKE Build type so CA1852 is satisfied when the build project is compiled in CI. Add a FromConfiguration conversion alternative for Configuration to satisfy CA2225 without suppressing analyzer diagnostics. Verification: dotnet build build/_build.csproj -c Release /warnaserror; dotnet build src/Extensions.Hosting.slnx -c Release --no-restore /m:1 /p:BuildInParallel=false.
Add 11.0.x to setup-dotnet in BuildOnly and BuildDeploy so CI can compile the new net11.0 target frameworks. Verification: git diff --check.
Remove setup-dotnet package caching now that the workflows already use a dedicated actions/cache step for NuGet packages and NUKE temp data. This prevents the setup-dotnet post step from spending excessive time saving duplicate cache data after successful build and test steps. Verification: git diff --check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature and maintenance migration.
This migrates the solution to Central Package Management, ReactiveUI.Primitives-based package references, StyleSharp.Analyzers 3.16.0, and net11.0/net11.0-* target frameworks. It also fixes analyzer findings, updates examples, and expands TUnit coverage.
What is the new behavior?
Directory.Packages.props.What is the current behavior?
Checklist
Additional information
Validation performed:
dotnet build Extensions.Hosting.slnx -c Release --no-restore /m:1 /p:BuildInParallel=falsepassed with 0 warnings and 0 errors before the final ReactiveAvalonia template fix.dotnet build examples/Extensions.Hosting.ReactiveAvalonia.Example/Extensions.Hosting.ReactiveAvalonia.Example.csproj -c Release --no-restore /m:1 /p:BuildInParallel=falsepassed with 0 warnings and 0 errors after the template fix.dotnet test --solution Extensions.Hosting.slnx -c Releasepassed 194/194. The solution test command still emits unrelated analyzer warnings from other projects.rgfound no directSystem.Reactivereferences outsidebin/obj.reactiveui, and visually confirmed populated rows with icons, titles, descriptions, and Open buttons.