fix(build): honor MinVer floor for release bumps#262
Merged
Conversation
Versioning: - Replace the floor-blind release bump action with a floor-aware release version calculation seeded from the MinVer 3.2 floor until a newer vX.Y.Z tag exists. - Pass the resolved MinVerVersionOverride through MinVer, build, and pack so a Major release from the 3.2 baseline stamps 4.0.0. Validation: - Verified the no-v-tag Major calculation resolves version=4.0.0 and tag=v4.0.0. - Verified solution-level dotnet pack with MinVerVersionOverride=4.0.0 produces 4.0.0 packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Build/release workflow fix for MinVer version stamping.
What is the new behavior?
BuildDeploy.ymlcomputes release versions from the MinVer3.2floor when no matchingvX.Y.ZRTM tag exists. With a Major release selected in that migration state, the workflow resolvesversion=4.0.0andtag=v4.0.0, then passes that exact version through MinVer, build, and pack.What is the current behavior?
The workflow used
reactiveui/actions-common/.github/actions/compute-version-and-tag, which seeds from0.0.0when no matchingvX.Y.ZRTM tag is reachable. That value was passed to MinVer asversion-override, bypassingMinVerMinimumMajorMinor=3.2and causing Major to build as1.0.0.Checklist
Additional information
Validation:
v*RTM tags:version=4.0.0,tag=v4.0.0,prerelease=false.src/Extensions.Hosting.SingleInstance/Extensions.Hosting.SingleInstance.csprojwithMinVerVersionOverride=4.0.0and verified the.nuspecversion is4.0.0.MinVerVersionOverride=4.0.0; it produced 47.nupkg/symbol packages stamped4.0.0.Note: solution pack still emits existing
NU5104warnings for stable packages depending on preview dependencies; that is separate from the MinVer release floor fix.