Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

Fix #9; adds static "type" property to conform to i18next API#10

Open
karoun wants to merge 4 commits into
reactwaylabs:masterfrom
karoun:karoun/fix-type
Open

Fix #9; adds static "type" property to conform to i18next API#10
karoun wants to merge 4 commits into
reactwaylabs:masterfrom
karoun:karoun/fix-type

Conversation

@karoun
Copy link
Copy Markdown

@karoun karoun commented Apr 2, 2023

What changed?

  • See title; a static type property is required, per i18next documentation
  • Raises plugin error when namespace is missing, rather than a console.error() (which I suspect was accidental)
  • Turns i18next into a dev-only dependency since only its types are used; it isn't needed at plugin runtime

Test plan

  • Ensure npm run build completes successfully

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant