add open telemetry#9
Open
odyvangelis wants to merge 16 commits into
Open
Conversation
metalcorpe
approved these changes
Mar 31, 2026
Collaborator
metalcorpe
left a comment
metalcorpe
left a comment
There was a problem hiding this comment.
-
There is 1 left => log.Printf("proxy warning: peer %s is trusted but no valid client IP found in headers %v, falling back to peer address", r.RemoteAddr, cfg.RealIPHeaders)
-
I think DB needs expliti instrumentation by injecting the context
Collaborator
Author
|
@metalcorpe agree on db, i was thinking of doing it in a new pr so we can also pass context to queries and do general db cleanup. Also i will probaby open a new pr in this chain for the metrics/prometheus side of things |
Collaborator
|
@odyvangelis try to also merge some of them 😂😂😂 |
dliaskos
reviewed
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.