add DishkaRouter for integrations/litestar.py#331
Open
chesnokpeter wants to merge 2 commits intoreagento:developfrom
Open
add DishkaRouter for integrations/litestar.py#331chesnokpeter wants to merge 2 commits intoreagento:developfrom
integrations/litestar.py#331chesnokpeter wants to merge 2 commits intoreagento:developfrom
Conversation
Tishka17
reviewed
Jan 7, 2025
| .venv/ No newline at end of file | ||
| .venv/ | ||
|
|
||
| uv.lock No newline at end of file |
Member
There was a problem hiding this comment.
not related to PR
anyway, we do not use lock here as we develop library
Member
|
Member
|
Hi. Please, provide answers on questions above. This feature looks interesting, but we need to be sure that no updates are expected. I guess, we can handle them on our side if provided some info |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to fastapi, i added
DishkaRouterto get each handler to not need to hang@injecton every handler