[#999] Add GPT-5.6 Sol/Terra/Luna to codex model dropdown#1000
Merged
Conversation
Append gpt-5.6-sol/terra/luna to MODEL_OPTIONS.codex after the existing
concrete rows so modelsForBackend("codex")[0] stays "gpt-5.4" (#931
default/heal target). Pure data addition; effectiveModel/sanitizeModel
already handle any concrete slug. Adds a test asserting optionsForBackend(
"codex") includes the 3 new slugs.
Closes #999
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
Author
|
@re2 APPROVE at Pure data addition per #999, behavior-preserving for existing agents. Standard QuadWork flow (standalone, not EPIC #967). Checked (evidence)
No concerns. Both-approval + CI-green gate met on the review side; @Head merges per standard rule. |
project7-interns
approved these changes
Jul 13, 2026
project7-interns
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: APPROVE
Epic Alignment: PASS
Standalone #999 contract is met: only MODEL_OPTIONS.codex gains the three GPT-5.6 slugs, labels match values, and modelsForBackend("codex")[0] remains gpt-5.4.
Checked (evidence)
- Structural gate: PR body has filled
## EPIC Alignmentand## Self-Verification; UI design table not required for this data-only dropdown option change. - Issue context:
gh issue view 999→ standalone, parent none; contract requiressrc/lib/agentModels.tscodex-only append, no reorder, no logic/spawn/UI refactors. - Scope:
gh pr diff 1000/ REST files → exactlysrc/lib/agentModels.ts(+6) andserver/agentModels.test.js(+1), no deletions. - Model rows:
src/lib/agentModels.ts:19,src/lib/agentModels.ts:20,src/lib/agentModels.ts:21addgpt-5.6-sol,gpt-5.6-terra,gpt-5.6-lunawithlabel == valueafter existing concrete codex rows. - Ordering invariant:
server/agentModels.test.js:39still pinsmodelsForBackend("codex")[0] === "gpt-5.4". - New coverage:
server/agentModels.test.js:34assertsoptionsForBackend("codex")includes all three new slugs. - Consumer path:
src/components/AgentModelsWidget.tsx:25andsrc/components/AgentModelsWidget.tsx:248useoptionsForBackend;src/components/SettingsPage.tsx:6imports shared helpers from@/lib/agentModels. - Riskiest part of this diff: stale duplicate model catalogs would make the UI miss the new slugs; checked PR head consumers and they read the shared helper, so acceptable.
- Kill-list: scanned all items — clean.
- CI:
gh pr checks 1000→test pass 51s.
Findings
None.
Decision
Approve. The PR is the requested data-only addition with focused test coverage and no behavior-changing logic outside the model catalog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #999
EPIC Alignment
~/.quadwork/config.json.MODEL_OPTIONS.codex.effectiveModel/sanitizeModelalready accept any concrete slug.Self-Verification
src/lib/agentModels.tsappends 3 rows AFTER the existing concrete codex rows (label == value);server/agentModels.test.jsadds one assertion.modelsForBackend("codex")[0]stays"gpt-5.4"(the Settings: agent Model dropdown hardcoded to Claude models — not provider-aware (shows 'sonnet' for Codex/Gemini agents) #931 default/heal target) — no reorder. Existing test line 38 still guards this.effectiveModel/sanitizeModelunchanged.node server/run-tests.js→ 64 passed, 0 failed, 2 skipped (Jest-style, pre-existing Unref routes.js module-load pollers + add cross-platform 'npm test' (fix full-suite hang) #836 skips). New assertion:optionsForBackend("codex")includesgpt-5.6-sol/gpt-5.6-terra/gpt-5.6-luna→ PASS.npx tsc --noEmit→ clean (exit 0).Deviations
none
🤖 Generated with Claude Code