Conversation
Jesse-rtr
force-pushed
the
RT-17796
branch
4 times, most recently
from
18b502e to
523ebe2
Compare
zbrag
previously approved these changes
Apr 21, 2026
| }, | ||
| "wdrpNotifications": false, | ||
| "errpNotifications": false, | ||
| "transferLockDays": 0 |
Member
There was a problem hiding this comment.
These tests are all very much the same, wouldn't it be wise to have some differences between them?
Contributor
Author
There was a problem hiding this comment.
It tests the mapping of json, as long as the values are legal it's fine. Changed one of the bools since it doesn't (or at least shouldn't) matter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.