Update deps, improve bs config, add Redirect binding#7
Update deps, improve bs config, add Redirect binding#7chenglou merged 1 commit intoreasonml-old:masterfrom emmenko:patch-1
Conversation
|
Thanks! Btw you might have seen the new https://reasonml.github.io/reason-react/docs/en/router.html. Give it a try! I'm moving this repo to reasonml-old for now. |
|
Just saw that yes, looks pretty neat with pattern matching! 🙌 Btw: isn’t the notice in the readme enough? People with existing projects would still be using the bindings I suppose 🤔 |
|
We're not deleting the library for sure! Just that keeping it inside reasonml-community is slightly of a burden (for me. I use a multi-codebases git workflow). The new RR router also interops with your existing code, so I think converting react router part to RR router might not be that much more work vs converting to bs-react-router first. But if someone wants to handle it by moving to his/her own repo, that's nice too. |
|
Yeah I understand. I guess I’ll have to try it out first to see how much effort it is (at least for me) 😄 |
Small improvements. I left out some other improvements which are covered by the #6 PR.
In details:
in-sourcemode to generate*.bs.jsfiles next to the sourcees6bs-platformas apeerDependencymatchobject shape (params)RedirectcomponentwithROuterfunction