Fix stackoverflow in unparseExprRecurse#2290
Merged
chenglou merged 1 commit intoDec 12, 2018
Merged
Conversation
This is an alternative to reasonml#2289 that also renames `literalAttrs` to `stylisticAttrs` as request in reasonml#2223's code review
anmonteiro
force-pushed
the
anmonteiro/fix-stack-overflow-in-preserve-braces
branch
from
December 11, 2018 13:24
d3a5c69 to
2413278
Compare
Contributor
|
cc @chenglou cherry pick it for a release? |
anmonteiro
deleted the
anmonteiro/fix-stack-overflow-in-preserve-braces
branch
December 20, 2018 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2289 that also renames
literalAttrstostylisticAttrsas request in #2223's code review