Fix JSX removing semicolons#2406
Merged
Merged
Conversation
jordwalke
reviewed
May 7, 2019
| uri | ||
| />; | ||
| } | ||
| {let uri = "/images/header-background.png"; |
Member
There was a problem hiding this comment.
We don't have this form of wrapping anywhere else (not intentionally at least). Is there a reason why this isn't breaking into multiple lines?
{
let uri =
...
}
Member
Author
There was a problem hiding this comment.
This has been here for a while, e.g. #2208.
We did it initially to save space on JSX patterns like:
<div>
{
React.string("foo")
}
</div>
Member
|
Thank you for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we can have our cake and eat it too. This fixes e.g. #2384 and a few others, resulting from a bug I introduced in #2223