fix: replace main page hero image with hero-img.png and improve acces…#1897
fix: replace main page hero image with hero-img.png and improve acces…#1897kotebhakti30 wants to merge 1 commit into
Conversation
kotebhakti30
requested review from
Adez017,
iitzIrFan and
sanjay-kv
as code owners
|
@kotebhakti30 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
in-review
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
github-actions
Bot
added
Enhacement
|
✅ Synchronized metadata from Issue #1498:
|
|
|
||
| <div | ||
| className="m-4" | ||
| onClick={() => (window.location.href = "https://www.sanjaykv.com/")} | ||
| > | ||
| <img | ||
| src="/selfhero.png" | ||
| alt="recodehive" | ||
| className="h-full w-full cursor-pointer rounded-2xl object-cover" | ||
| /> | ||
| <div className="m-4"> | ||
| <a | ||
| href="https://www.sanjaykv.com/" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="block overflow-hidden rounded-2xl shadow-lg transition-transform duration-300 hover:scale-[1.01]" | ||
| > | ||
| <img | ||
| src="/img/hero-img.png" | ||
| alt="ReCode Hive - Learn to Code" | ||
| className="h-full w-full object-cover" | ||
| loading="lazy" |
There was a problem hiding this comment.
@kotebhakti30 i thinki you didn't able to understand the issue completely . the main task is to replace the image highlighted in the issue with the builder note kind of image that we had pointed out . this is not the desired changes . Please take a look onto the issue
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kotebhakti30
force-pushed
the
fix/replace-main-page-image
branch
from
03d000a to
e3cc1c3
Compare
|
✅ Synchronized metadata from Issue #1498:
|
|
|
||
| <div | ||
| className="m-4" | ||
| onClick={() => (window.location.href = "https://www.sanjaykv.com/")} |
There was a problem hiding this comment.
kotebhakti30
force-pushed
the
fix/replace-main-page-image
branch
from
e3cc1c3 to
ffdc8ba
Compare
|
✅ Synchronized metadata from Issue #1498:
|
| className="m-4" | ||
| onClick={() => (window.location.href = "https://www.sanjaykv.com/")} | ||
| > | ||
| <div className="m-4"> |
There was a problem hiding this comment.
plz bring back,
onClick={() => (window.location.href = "https://www.sanjaykv.com/")}
rest looks good to me though!
| src="/hero-builder-note.svg" | ||
| alt="Dear Coder — a note from the ReCode Hive team" | ||
| className="h-full w-full rounded-2xl object-cover shadow-md" | ||
| loading="lazy" |
|
Hi @sanjay-kv, I want to get this right before reopening the PR. Could you clarify what the "builder note kind of image" should look like? For example: A specific image file already in the repo I should use? Also confirming I'll restore the onClick handler as requested by @iitzIrFan. Thanks! |
@kotebhakti30 The image is what referenced in the builders club , we want something or exact replica of that for recodehive . |
4 participants
PR Title: fix: replace main page hero image with hero-img.png
PR Description:
Summary
Replaces the current /selfhero.png hero image on the main page with /img/hero-img.png, improving visual appeal and accessibility as referenced in the issue.
Changes
src/pages/index.tsx
Replaced /selfhero.png with /img/hero-img.png
Replaced inline onClick navigation with a proper tag with target="_blank" and rel="noopener noreferrer" for better accessibility and security
Added loading="lazy" to the image for better performance
Added hover scale transition effect for better UX
Kept existing margin and rounded corner styling
Expected Outcome
Homepage displays the updated hero image
Image is fully responsive across desktop and mobile
No visual regressions to surrounding UI elements
Page performance maintained with lazy loading
Related Issues
Closes #1498