RHOAIENG-78039: add extraEnvVars to XKS helm chart#26990
Open
jira-autofix[bot] wants to merge 1 commit into
Open
RHOAIENG-78039: add extraEnvVars to XKS helm chart#26990jira-autofix[bot] wants to merge 1 commit into
jira-autofix[bot] wants to merge 1 commit into
Conversation
Add a new rhaiOperator.extraEnvVars key to the XKS helm chart values and update the deployment template to iterate over it. This allows UPSTREAM_VERSION env vars (which are version strings, not container image references) to be placed separately from relatedImages, which is semantically reserved for actual container image digests. Assisted-by: Claude claude-opus-4-6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
rhaiOperator.extraEnvVarskey to the XKS helm chart and update the deployment template to iterate over it.Problem
The 15
RELATED_IMAGE_RHAII_VLLM_*_UPSTREAM_VERSIONenv vars in the XKS helm chart are version strings (e.g.,0.21.0+rhaiv.10), not container image references. They are currently injected intorhaiOperator.relatedImageswhich is semantically reserved for actual container image digests.Changes
to-be-processed/helm/rhai-on-xks-chart/values.yaml: AddedrhaiOperator.extraEnvVars: []with documentation and example usage.to-be-processed/helm/rhai-on-xks-chart/templates/manager/deployment-rhods-operator.yaml: Added a template range loop over.Values.rhaiOperator.extraEnvVarsto inject these env vars into the operator deployment, in addition to the existingrelatedImagesloop.Dependencies
Depends on RHOAIENG-78031 (RHOAI-Konflux-Automation must inject into
extraEnvVarsinstead ofrelatedImages).