Skip to content

RHAIENG-6078: Upgrade code-server from v4.106.3 to v4.112.0#2484

Draft
ysok wants to merge 1 commit into
red-hat-data-services:mainfrom
ysok-red-hat-data-services:rhds-upgrade-codeserver
Draft

RHAIENG-6078: Upgrade code-server from v4.106.3 to v4.112.0#2484
ysok wants to merge 1 commit into
red-hat-data-services:mainfrom
ysok-red-hat-data-services:rhds-upgrade-codeserver

Conversation

@ysok

@ysok ysok commented Jul 10, 2026

Copy link
Copy Markdown

RHAIENG-6078: Upgrade code-server from v4.106.3 to v4.112.0

Description

Upgrade code-server from v4.106.3 to v4.112.0 (VS Code 1.112.0, Node 22.22.0) for the ubi9-python-3.12 workbench image. Refresh the prefetch submodule, Tekton prefetch paths, Dockerfile (git-lfs, version bumps), and replace the v4.106.3 patch overlay with v4.112.0 — including regenerated npm lockfiles, pinned rolldown-vite, gulpfile.reh.ts ppc64/s390x targets, and js-debug 1.112.0. Add ppc64/s390x build fixes for VS Code 1.112’s tsgo dependency: fall back to tsc, serialize extension packaging, skip noEmit typecheck under QEMU, and cap Node heap. Validated with sandbox tests and local hermetic builds on arm64 and ppc64le.

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions

Copy link
Copy Markdown

@ysok — This PR is from a fork.
The build-rhoai CI job was skipped because subscription
builds (RHEL, AIPCC) need secrets unavailable to forks.
ODH builds and code quality checks still ran.

Recommended: Push your branch to the main repo for full CI:

git remote add upstream https://github.com/red-hat-data-services/notebooks.git
git push upstream HEAD:ysok/your-branch-name

Then open a new PR from that branch.

No push access? A maintainer will cherry-pick and test your changes.

See CONTRIBUTING.md for details.

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jiridanek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fbb1b902-b7bc-4f51-8498-510562e60c3f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ysok

ysok commented Jul 10, 2026

Copy link
Copy Markdown
Author

/build-codeserver

@ysok

ysok commented Jul 10, 2026

Copy link
Copy Markdown
Author

Konflux builds were good.

image

There were failure in FIPs, a known issue and not related to this PR.

`++ which podman

  • PODMAN=/usr/bin/podman
    ++ sudo /usr/bin/podman image mount ghcr.io/red-hat-data-services/notebooks/workbench-images:codeserver-ubi9-python-3.12-main_ab73a4c_rhoai_linux_arm64
  • IMAGE_MOUNT_DIR=/mnt/containers/storage/overlay/4f93fc679b61c1a3ba4caa3224b9313bcff3b56ceeec39d1ab49faacf5b26f5f/merged
  • sudo /usr/bin/podman run --rm --user=0 -v /mnt/containers/storage/overlay/4f93fc679b61c1a3ba4caa3224b9313bcff3b56ceeec39d1ab49faacf5b26f5f/merged:/mnt/containers/storage/overlay/4f93fc679b61c1a3ba4caa3224b9313bcff3b56ceeec39d1ab49faacf5b26f5f/merged:ro,z -v /home/runner/work/notebooks/notebooks/scripts/check-payload/config.toml:/config.toml:ro,z ghcr.io/red-hat-data-services/notebooks/check-payload:0.3.16 scan local --path /mnt/containers/storage/overlay/4f93fc679b61c1a3ba4caa3224b9313bcff3b56ceeec39d1ab49faacf5b26f5f/merged -c /config.toml
    Trying to pull ghcr.io/red-hat-data-services/notebooks/check-payload:0.3.16...
    Error: unable to copy from source docker://ghcr.io/red-hat-data-services/notebooks/check-payload:0.3.16: initializing source docker://ghcr.io/red-hat-data-services/notebooks/check-payload:0.3.16: unable to retrieve auth token: invalid username/password: unauthorized
    Error: Process completed with exit code 125.`

@ysok
ysok force-pushed the rhds-upgrade-codeserver branch from fe3962d to 53836d6 Compare July 10, 2026 15:48
@konflux-internal-p02

Copy link
Copy Markdown

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
odh-workbench-codeserver-datascience-cpu-py312-pull-request.yaml yaml validation error: line 183: could not find expected ':'

@ysok

ysok commented Jul 10, 2026

Copy link
Copy Markdown
Author

/build-codeserver

@ysok
ysok force-pushed the rhds-upgrade-codeserver branch from 6394b95 to 092a739 Compare July 10, 2026 16:26
@ysok

ysok commented Jul 10, 2026

Copy link
Copy Markdown
Author

/build-codeserver

@ysok
ysok force-pushed the rhds-upgrade-codeserver branch from 092a739 to 9518db8 Compare July 11, 2026 00:12
@ysok

ysok commented Jul 11, 2026

Copy link
Copy Markdown
Author

/build-codeserver

1 similar comment
@ysok

ysok commented Jul 11, 2026

Copy link
Copy Markdown
Author

/build-codeserver

@ysok

ysok commented Jul 11, 2026

Copy link
Copy Markdown
Author

@ysok
ysok force-pushed the rhds-upgrade-codeserver branch from ec94cdd to 0a48e54 Compare July 11, 2026 13:06
@ysok

ysok commented Jul 11, 2026

Copy link
Copy Markdown
Author

/build-codeserver

@ysok

ysok commented Jul 11, 2026

Copy link
Copy Markdown
Author

All builds were good, but failed with FIPS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant