[rhoai-2.25] RHAIENG-6036: skip PDF export on s390x and ppc64le via container_arch#2497
Conversation
Backport the container_arch fixture approach from main (opendatahub-io#3472) instead of starting a throwaway container inside test_pdf_export. PDF export is not supported on these architectures; the skip is not a CI flake workaround. (cherry picked from commit 3e4958b) Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 48 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesContainer architecture testing
Estimated code review effort: 3 (Moderate) | ~15–30 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…tainer_arch Session-scoped container_arch depends on image; metafunc.parametrize must pass scope="session" or pytest raises ScopeMismatch (pytest #634). Co-authored-by: Cursor <cursoragent@cursor.com>
|
@coderabbitai full review |
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/containers/conftest.py`:
- Around line 61-68: Add a descriptive failure message to the `assert
image_option is not None` guard in the parametrization logic, clearly stating
that the `--image` option must be provided.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 23c775c0-2084-43f5-8745-a5befe9b5f93
📒 Files selected for processing (2)
tests/containers/conftest.pytests/containers/workbenches/jupyterlab/jupyterlab_test.py
Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ide-developer The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary
container_archsession fixture (backported from ODHmain#3472) that runsuname -monce per image under test.test_pdf_exportto skip ons390xandppc64leusing that fixture, matchingmain.A full
cherry-pick -xof opendatahub-io#3472 does not apply cleanly onrhoai-2.25(12 files,BestEffortCleanup, fixture scoping changes, etc.). This PR carries only the PDF-export/arch-detection slice.The skip reason is platform support, not “unreliable in CI”.
Test plan
pytest-tests/ pre-commit greenjupyter-minimal-ubi9-python-3.12ppc64le + s390x matrix jobs skiptest_pdf_exportinstead of failingtest_pdf_exportstill runsFollow-up
Drop the duplicate PDF-export hunk from #2488 once this merges.
Made with Cursor
Summary by CodeRabbit