Skip to content

[rhoai-3.3] fix(ci): guard pylock downgrade fetch against null push SHA#2501

Open
jiridanek wants to merge 1 commit into
rhoai-3.3from
fix/rhoai-3.3-on-demand-pylock-fetch
Open

[rhoai-3.3] fix(ci): guard pylock downgrade fetch against null push SHA#2501
jiridanek wants to merge 1 commit into
rhoai-3.3from
fix/rhoai-3.3-on-demand-pylock-fetch

Conversation

@jiridanek

Copy link
Copy Markdown
Member

Summary

  • Skip git fetch when github.event.before is GitHub's all-zeros null SHA (first push of a new branch).
  • Add if: guard so the fetch step only runs after deps install succeeds.

Fixes the spurious pytest-tests failure seen on #2478.

Tracks upstream design in opendatahub-io/notebooks#4051.

Test plan

  • Push a new branch to RHDS and confirm pytest-tests no longer fails on upload-pack: not our ref 000…000
  • Open/update a PR against rhoai-3.3 and confirm pylock downgrade checks still run

Made with Cursor

Skip git fetch when github.event.before is the all-zeros SHA sent on the
first push of a new branch. Aligns with opendatahub-io#4051.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci
openshift-ci Bot requested review from atheo89 and ysok July 10, 2026 13:01
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ysok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jiridanek, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4cf55931-5d99-4422-9aa4-31d42ac680fb

📥 Commits

Reviewing files that changed from the base of the PR and between 45a9953 and bf7e666.

📒 Files selected for processing (1)
  • .github/workflows/code-quality.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rhoai-3.3-on-demand-pylock-fetch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jiridanek jiridanek changed the title fix(ci): guard pylock downgrade fetch against null push SHA [rhoai-3.3] fix(ci): guard pylock downgrade fetch against null push SHA Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant