[rhoai-3.4] fix(ci): use on-demand fetch for pylock downgrade baseline#2502
[rhoai-3.4] fix(ci): use on-demand fetch for pylock downgrade baseline#2502jiridanek wants to merge 1 commit into
Conversation
Drop fetch-depth: 0 from pytest-tests and fetch only the event baseline commit when needed. Skip fetch for GitHub's null github.event.before SHA on the first push of a new branch. Aligns with opendatahub-io#4051. Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
fetch-depth: 0frompytest-tests(shallow checkout by default).git fetch --depth=1for the pylock downgrade baseline (pull_request.base.shaorgithub.event.before).github.event.beforeis the all-zeros null SHA on the first push of a new branch.Implements the release-branch side of opendatahub-io/notebooks#4051 for
rhoai-3.4.Test plan
pytest-testspasses on a PR againstrhoai-3.4test_pylock_downgradestill compares against the PR base / previous push tipMade with Cursor