Skip to content

[rhoai-3.4] fix(ci): use on-demand fetch for pylock downgrade baseline#2502

Open
jiridanek wants to merge 1 commit into
rhoai-3.4from
fix/rhoai-3.4-on-demand-pylock-fetch
Open

[rhoai-3.4] fix(ci): use on-demand fetch for pylock downgrade baseline#2502
jiridanek wants to merge 1 commit into
rhoai-3.4from
fix/rhoai-3.4-on-demand-pylock-fetch

Conversation

@jiridanek

Copy link
Copy Markdown
Member

Summary

  • Remove fetch-depth: 0 from pytest-tests (shallow checkout by default).
  • Add a targeted git fetch --depth=1 for the pylock downgrade baseline (pull_request.base.sha or github.event.before).
  • Skip fetch when github.event.before is the all-zeros null SHA on the first push of a new branch.

Implements the release-branch side of opendatahub-io/notebooks#4051 for rhoai-3.4.

Test plan

  • Confirm pytest-tests passes on a PR against rhoai-3.4
  • Confirm first push of a new branch no longer needs full history checkout
  • Confirm test_pylock_downgrade still compares against the PR base / previous push tip

Made with Cursor

Drop fetch-depth: 0 from pytest-tests and fetch only the event baseline
commit when needed. Skip fetch for GitHub's null github.event.before SHA on
the first push of a new branch. Aligns with opendatahub-io#4051.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci
openshift-ci Bot requested review from atheo89 and ayush17 July 10, 2026 13:01
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign daniellutz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 56a346b9-ee5c-4bf9-ae1c-1082a93c6e4d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rhoai-3.4-on-demand-pylock-fetch
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/rhoai-3.4-on-demand-pylock-fetch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jiridanek jiridanek changed the title fix(ci): use on-demand fetch for pylock downgrade baseline [rhoai-3.4] fix(ci): use on-demand fetch for pylock downgrade baseline Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant