[rhoai-2.25] RHAIENG-6036: restore check-payload workbench FIPS waivers#2551
Merged
Merged
Conversation
📝 WalkthroughWalkthroughChangesPayload check configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
ide-developer
approved these changes
Jul 22, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ide-developer The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore the pre-#2513
check-payloadexcludes for workbench images so Build Notebooks / PR matrix stops failing FIPS on static binaries that 2.25 still ships.What #2513 removed (incorrect for 2.25)
Main-oriented comments claimed py-spy is gone (
exclude-dependencies) and pandoc is dynamic (pandoc-rhai). Onrhoai-2.25:pylock.toml→/opt/app-root/bin/py-spyfailsErrNotDynLinked/usr/local/pandoc/bin/pandoc(until #2550 RPM path)Restored
[[rpm.rstudio-server.ignore]]blocks (pandoc, typst, esbuild)[[payload.python-311-container.ignore]]+[[ignore]]for/opt/app-root/bin/py-spy[[ignore]]for/usr/local/pandoc/bin/pandocKept from #2513
@anthropic-ai/sandbox-runtimeseccomp dir ignores (covers #2500’s intent; that PR can close as superseded once this lands)Independent of #2550 (PDF RPM) and #2534 (openblas).
How Has This Been Tested?
pandoc/py-spyErrNotDynLinked)Self checklist:
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria:
Made with Cursor
Summary by CodeRabbit