[rhoai-2.25] RHAIENG-2345: subscribe Build Notebooks push (non-codeserver)

[jiridanek]

Description

After #2550 switched PDF deps to AppStream/EPEL RPMs, two CI paths still built unsubscribed and fail dnf install texlive-*:

1. Build Notebooks (push)

gen_gha_matrix_jobs.py sets "subscription": "rhel" in target, and push passed that through → jobs named …, false) (e.g. run 29916877152).

Fix: match build-notebooks-pr.yaml: subscription: ${{ !contains(matrix.target, 'codeserver') }}.

2. Test Build Notebooks Template (PR check)

Hardcoded subscription: false → same AppStream miss. Breaks any PR that triggers the template self-test (paths under .github/workflows/, Makefile, etc.), e.g. #2540 / job 88918051263 (subscription: false, No match for argument: texlive-adjustbox).

Fix: subscription: ${{ true }} (#2310).

Codeserver stays unsubscribed (hermetic public UBI locks). Same-repo secrets required; fork PRs that touch these paths will fail without them (see CONTRIBUTING.md).

How Has This Been Tested?

• https://github.com/red-hat-data-services/notebooks/actions/runs/29919884418

• Diff: push override identical to PR workflow expression
• Test Build Notebooks Template on this PR: subscription: true, past install_pdf_deps
• After merge: Build Notebooks (push) on rhoai-2.25 shows …, true) for non-codeserver

Self checklist:

• Ensure that you have run make test (gmake on macOS) before asking for review
• Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[coderabbitai]

📝 Walkthrough

Walkthrough

Changes

Notebook build subscription handling

Layer / File(s)	Summary
Target-based push build subscription .github/workflows/build-notebooks-push.yaml	The push workflow derives subscription from matrix.target, enabling it for non-codeserver targets.
Template self-test subscription .github/workflows/test-build-notebooks-template.yaml	The template self-test always enables subscription and documents its RHEL AppStream texlive dependency.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

• Test Build Notebooks Template fails: texlive RPMs unavailable without EPEL/subscription in install_pdf_deps.sh #2310 — Matches the template workflow change enabling subscription for RHEL AppStream texlive RPMs.

Possibly related PRs

• red-hat-data-services/notebooks#2439 — Also updates subscription handling for reusable notebook build workflows.
• red-hat-data-services/notebooks#2525 — Also changes how RHEL subscription access is enabled for notebook builds.

Suggested reviewers: ide-developer

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly names the push-build subscription change and is specific to the main non-codeserver update.
Description check	✅ Passed	The PR body includes the required Description and How Has It Been Tested sections plus checklist items, with only a few unchecked items.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/rhoai-2.25-push-subscribe

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

.github/workflows/test-build-notebooks-template.yaml (1)

38-38: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Use a literal boolean for the static value.

Replace ${{ true }} with true; this preserves the boolean input while avoiding zizmor’s obfuscated-expression warning.

Proposed fix

-      subscription: ${{ true }}
+      subscription: true

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/test-build-notebooks-template.yaml at line 38, Update the
static subscription value in the workflow to use the literal boolean true
instead of the expression-wrapped value, preserving it as a boolean input and
avoiding the obfuscated-expression warning.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/test-build-notebooks-template.yaml:
- Line 38: Update the static subscription value in the workflow to use the
literal boolean true instead of the expression-wrapped value, preserving it as a
boolean input and avoiding the obfuscated-expression warning.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 93bfb347-d54b-4cff-84e1-c2c2235c14de

📥 Commits

Reviewing files that changed from the base of the PR and between e8b1136 and a87b3d6.

📒 Files selected for processing (2)

• .github/workflows/build-notebooks-push.yaml
• .github/workflows/test-build-notebooks-template.yaml

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ide-developer
Once this PR has been reviewed and has the lgtm label, please assign jiridanek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment