Minimize FreeSpace nesting#754
Open
rbs-afflitto wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
RemoveFreeSpaceModifiernow creates remaining free space as siblings instead of children.Link to Related Issue(s)
#753
Please describe the changes in your request.
RemoveFreeSpaceModifier creates remaining FreeSpace as siblings to the original resource rather than children. Previously, the new FreeSpace would be created as children to the original, then the original's tags removed. This had the potential to create unbounded deep nesting of MemoryRegion resources when allocating many times.
Anyone you think should look at this, specifically?
@rbs-jacob