Skip to content

[release-4.21] OCPBUGS-83583: Fix EventOutCh deadlock by making publish non-blocking#665

Open
openshift-cherrypick-robot wants to merge 1 commit intoredhat-cne:release-4.21from
openshift-cherrypick-robot:cherry-pick-664-to-release-4.21
Open

[release-4.21] OCPBUGS-83583: Fix EventOutCh deadlock by making publish non-blocking#665
openshift-cherrypick-robot wants to merge 1 commit intoredhat-cne:release-4.21from
openshift-cherrypick-robot:cherry-pick-664-to-release-4.21

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 16, 2026

This is an automated cherry-pick of #664

/assign jzding

@jzding
Fix EventOutCh deadlock by making publish non-blocking
6cd5882 
PublishEventViaAPI sends to EventOutCh with a blocking channel send.
When ProcessOutChannel (the consumer) is slow due to HTTP POST failures
(e.g., unreachable subscribers), the 100-slot buffer fills up and the
next publish blocks forever. This deadlocks the processMessages
goroutine, freezing socket I/O and causing cloud-event-proxy to hang
silently.

Fix by using select with default to drop events when the channel is
full instead of blocking indefinitely. Dropped events are logged as
warnings and counted as failures in metrics.

Signed-off-by: Jack Ding <jackding@gmail.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 16, 2026
Merged
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from jzding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jzding jzding changed the title [release-4.21] OCPBUGS-83556: Fix EventOutCh deadlock by making publish non-blocking [release-4.21] OCPBUGS-83583: Fix EventOutCh deadlock by making publish non-blocking Apr 16, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 16, 2026

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-83583, which is invalid:

  • expected dependent Jira Issue OCPBUGS-83556 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-83556 to target a version in 4.22.0, but it targets "4.22.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #664

/assign jzding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aneeshkp aneeshkp Awaiting requested review from aneeshkp

@nocturnalastro nocturnalastro Awaiting requested review from nocturnalastro

Assignees

@jzding jzding

Labels

jira/invalid-bug jira/severity-critical jira/valid-reference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @openshift-ci-robot @jzding